Skip to content

[release-v1.14] Copy message before passing it to eventtype autocreate handler #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
May 23, 2024
Merged

[release-v1.14] Copy message before passing it to eventtype autocreate handler #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions pkg/kncloudevents/event_dispatcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@ import (
"net/http"
"time"

"github.com/cloudevents/sdk-go/v2/binding/buffering"

cloudevents "github.com/cloudevents/sdk-go/v2"
"github.com/cloudevents/sdk-go/v2/binding"
"github.com/cloudevents/sdk-go/v2/binding/buffering"
"github.com/cloudevents/sdk-go/v2/event"
cehttp "github.com/cloudevents/sdk-go/v2/protocol/http"
"github.com/hashicorp/go-retryablehttp"
Expand Down Expand Up @@ -248,7 +249,11 @@ func (d *Dispatcher) send(ctx context.Context, message binding.Message, destinat
messagesToFinish = append(messagesToFinish, responseMessage)

if config.eventTypeAutoHandler != nil {
d.handleAutocreate(ctx, responseMessage, config)
// messages can only be read once, so we need to make a copy of it
responseMessage, err = buffering.CopyMessage(ctx, responseMessage)
if err == nil {
d.handleAutocreate(ctx, responseMessage, config)
}
}

if config.reply == nil {
Expand Down Expand Up @@ -354,15 +359,8 @@ func (d *Dispatcher) executeRequest(ctx context.Context, target duckv1.Addressab
return ctx, responseMessage, &dispatchInfo, nil
}

func (d *Dispatcher) handleAutocreate(ctx context.Context, responseMessage binding.Message, config *senderConfig) {
// messages can only be read once, so we need to make a copy of it
messageCopy, err := buffering.CopyMessage(ctx, responseMessage)
if err != nil {
return
}
defer responseMessage.Finish(nil)

responseEvent, err := binding.ToEvent(ctx, messageCopy)
func (d *Dispatcher) handleAutocreate(ctx context.Context, msg binding.Message, config *senderConfig) {
responseEvent, err := binding.ToEvent(ctx, msg)
if err != nil {
return
}
Expand Down