Skip to content

[release-v1.16] MT-Broker: return retriable status code based on the state to leverage retries#975

Closed
pierDipi wants to merge 1 commit into
openshift-knative:release-v1.16from
pierDipi:cp-9740b128370d855ec7c01ec724b9c93693fee09d-v1.16
Closed

[release-v1.16] MT-Broker: return retriable status code based on the state to leverage retries#975
pierDipi wants to merge 1 commit into
openshift-knative:release-v1.16from
pierDipi:cp-9740b128370d855ec7c01ec724b9c93693fee09d-v1.16

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Dec 4, 2024

This is an automated cherry-pick of knative#8366

MT-Broker: return retriable status code based on the state to leverage retries

…tate to leverage retries (knative#8367)

* MT-Broker: return appropriate status code based on the state to leverage retries

The ingress or filter deployments were returning 400 even in the case
where a given resource (like trigger, broker, subscription) wasn't
found, however, this is a common case where the lister cache
hasn't caught up with the latest state.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Fix unit tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown

@pierDipi: Error creating a cherry-pick bug in Jira: failed to check the state of cherrypicked pull request at https://github.com/openshift-knative/eventing/pull/8366: status code 404 not one of [200], body: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"404"}.
Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

This is an automated cherry-pick of knative#8366

MT-Broker: return retriable status code based on the state to leverage retries

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from aliok and matzew December 4, 2024 12:45
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Dec 4, 2024
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Dec 4, 2024

Duplicate: #974

@pierDipi pierDipi closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants