🎁 Scan for main packages on imports

[cardil]

For vendorless projects we need to collect the test images from deps. This does that by scanning imports (usually the hack/tools.go file).

Part of SRVCLI-405

/kind enhancement

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign lberk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cardil]

/cc @pierDipi
/cc @creydr

[pierDipi]

As discussed on Slack, for kn-event-plugin we can leverage the reconciler-test file resolver https://github.com/knative-extensions/reconciler-test/tree/main/pkg/images/file with the help of the generate command as used here https://github.com/openshift-knative/eventing-istio/blob/e8680a4b989140e96986488dfbd76d1028f4a557/openshift/generate.sh#L48-L49

The benefits are:

• faster
• less resources
• less builds (big benefit as Konflux scalability is still a big challenge)
• more environmental friendly
• Cost savings
• less code to maintain as we wouldn't need scanning
• Reuse an existing feature

In the meantime, we decided that:

• kn-event-plugin will generate the production images with generate as that should work fine
• test images would be configured with static-images (custom Dockerfiles), similar to how Java images are maintained in EKB https://github.com/openshift-knative/eventing-kafka-broker/tree/main/openshift/ci-operator/static-images/dispatcher or equivalent approach
• For 1.37+, migrate to file resolver and get the other benefits

[cardil]

/close

[openshift-ci]

@cardil: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.