Skip to content

[release-v1.16] Pick Python scaffolding#1236

Merged
openshift-merge-bot[bot] merged 2 commits intorelease-v1.16from
release-v1.16-python-scaffolding
Apr 4, 2025
Merged

[release-v1.16] Pick Python scaffolding#1236
openshift-merge-bot[bot] merged 2 commits intorelease-v1.16from
release-v1.16-python-scaffolding

Conversation

@matejvasek
Copy link
Copy Markdown
Collaborator

@matejvasek matejvasek commented Apr 3, 2025

Picking knative#2685
Picking knative#2770

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@openshift-ci openshift-ci bot added the approved label Apr 3, 2025
@matejvasek matejvasek changed the title [release-v1.16] Pick Python scaffolding https://github.com/knative/func/pull/2685 [release-v1.16] Pick Python scaffolding Apr 3, 2025
@matejvasek
Copy link
Copy Markdown
Collaborator Author

@lkingland ^^^

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek requested review from dsimansk and removed request for jcrossley3 April 3, 2025 16:14
@matejvasek
Copy link
Copy Markdown
Collaborator Author

btw there is bunch of other backports needed beside this

@matejvasek
Copy link
Copy Markdown
Collaborator Author

PTAL @lkingland @dsimansk

@matejvasek
Copy link
Copy Markdown
Collaborator Author

@lkingland please carefully review this if I cherry-picked it correctly.

Copy link
Copy Markdown

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Looks right to me.
Wish we had the Python E2Es to be more sure, but expecting we get the pack support soon.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3e9c77f into release-v1.16 Apr 4, 2025
49 checks passed
@gauron99
Copy link
Copy Markdown

/cherry-pick release-v1.17

@openshift-cherrypick-robot
Copy link
Copy Markdown

@gauron99: #1236 failed to apply on top of branch "release-v1.17":

Applying: Pick https://github.com/knative/func/pull/2685
.git/rebase-apply/patch:18273: new blank line at EOF.
+
.git/rebase-apply/patch:18648: new blank line at EOF.
+
.git/rebase-apply/patch:18788: new blank line at EOF.
+
.git/rebase-apply/patch:18866: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	.github/workflows/test-e2e-runtime.yaml
M	.gitignore
M	Makefile
M	cmd/build.go
M	cmd/deploy_test.go
M	generate/zz_filesystem_generated.go
M	pkg/builders/s2i/builder.go
Falling back to patching base and 3-way merge...
Removing templates/python/wsgi/requirements.txt
Removing templates/python/wsgi/manifest.yaml
Removing templates/python/wsgi/func.py
Removing templates/python/wsgi/Procfile
Removing templates/python/http/test_func.py
Removing templates/python/http/requirements.txt
Removing templates/python/http/func.py
Removing templates/python/http/app.sh
Removing templates/python/http/Procfile
Removing templates/python/flask/requirements.txt
Removing templates/python/flask/manifest.yaml
Removing templates/python/flask/func.py
Removing templates/python/flask/Procfile
Removing templates/python/cloudevents/test_func.py
Removing templates/python/cloudevents/requirements.txt
Removing templates/python/cloudevents/func.py
Removing templates/python/cloudevents/app.sh
Removing templates/python/cloudevents/Procfile
Removing pkg/oci/containerize_test.go
Removing pkg/oci/containerize.go
Auto-merging pkg/builders/s2i/builder.go
Auto-merging generate/zz_filesystem_generated.go
CONFLICT (content): Merge conflict in generate/zz_filesystem_generated.go
Auto-merging cmd/deploy_test.go
Auto-merging cmd/build.go
Auto-merging Makefile
Auto-merging .gitignore
Auto-merging .github/workflows/test-e2e-runtime.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Pick https://github.com/knative/func/pull/2685

Details

In response to this:

/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants