[release-v1.16] Fix detection of hostname resolution failure

[matejvasek]

Fixing a bug where host name resolution failure was detected as a different kind of error.
Because of that on cluster dialer did not kick in and the operation failed immediately, instead of trying to tunneling connection via cluster.

[matejvasek]

/override "style / Golang / Lint"

[openshift-ci]

@matejvasek: Overrode contexts on behalf of matejvasek: style / Golang / Lint

Details

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-v1.16@40ce764). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-v1.16    #1318   +/-   ##
================================================
  Coverage                 ?   63.54%           
================================================
  Files                    ?      131           
  Lines                    ?    15810           
  Branches                 ?        0           
================================================
  Hits                     ?    10046           
  Misses                   ?     4799           
  Partials                 ?      965           

Flag	Coverage Δ
e2e-test	35.26% <0.00%> (?)
e2e-test-runtime-go	25.51% <0.00%> (?)
e2e-test-runtime-node	24.87% <0.00%> (?)
e2e-test-runtime-quarkus	24.96% <0.00%> (?)
e2e-test-runtime-rust	24.44% <0.00%> (?)
e2e-test-runtime-springboot	24.51% <0.00%> (?)
e2e-test-runtime-typescript	24.96% <0.00%> (?)
integration-tests	50.66% <0.00%> (?)
unit-tests	49.79% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gauron99]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gauron99]

/cherry-pick release-v1.17

[openshift-cherrypick-robot]

@gauron99: once the present PR merges, I will cherry-pick it on top of release-v1.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@gauron99: #1318 failed to apply on top of branch "release-v1.17":

Applying: Fix detection of hostname resolution failure
Using index info to reconstruct a base tree...
M	pkg/docker/pusher.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/docker/pusher.go
CONFLICT (content): Merge conflict in pkg/docker/pusher.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix detection of hostname resolution failure

Details

In response to this:

/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.