Use DomainMapping test with --customdomain option

[nak3]

DomainMapping test needs two domain like:

• original-ksvc.serverless.devcluster.openshift.com
• mydomain.example.com

We have a wildcard DNS for *.serverless.devcluster.openshift.com but cannot prepare for DNS the second domain mydomain.example.com so we used spoof client for the mydomain.example.com.
But if we changed the second domain to mydomain.serverless.devcluster.openshift.com, it should work.

Hence this patch changes to use --customdomain option.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3
To complete the pull request process, please assign mgencur after the PR has been reviewed.
You can assign the PR to them by writing /assign @mgencur in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nak3]

Ah, I think this PR also needs knative/serving@26c93b9 to be backported

[openshift-ci]

@nak3: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/4.7-upstream-e2e-aws-ocp-47	89ce900	link	/test 4.7-upstream-e2e-aws-ocp-47

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[nak3]

It still does not work but I am guessing the reason as the DomainMapping test does not use pkgtest.WaitForEndpointState which has RetryingRouteInconsistency. (And we add our patch to RetryingRouteInconsistency).
So CheckDistribution() accesses to the OpenShift Route before it is actually ready.

[nak3]

I realized that there are two issues in current test.

1. RetryingRouteInconsistency is necessary.
   2. --customdomain with cluster subdomain duplicated with the original ksvc's url. we need host = altHost + "." + test.ServingFlags.CustomDomain for the customdomain.

After 1 & 2, running the test locally and CI on 4.6 passed but 4.7 does not.

[nak3]

Closing for now.