Skip to content

kn-event sender image#1337

Merged
openshift-merge-robot merged 3 commits intoopenshift-knative:mainfrom
cardil:feature/kn-event-sender-image
Dec 14, 2021
Merged

kn-event sender image#1337
openshift-merge-robot merged 3 commits intoopenshift-knative:mainfrom
cardil:feature/kn-event-sender-image

Conversation

@cardil
Copy link
Copy Markdown
Member

@cardil cardil commented Dec 13, 2021

Adding kn-event sender image

Requires merge of openshift/release#24476

@openshift-ci openshift-ci bot requested review from lberk and skonto December 13, 2021 14:44
@cardil
Copy link
Copy Markdown
Member Author

cardil commented Dec 13, 2021

/cc @mgencur

@openshift-ci openshift-ci bot requested a review from mgencur December 13, 2021 14:44
@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Dec 13, 2021

Just for my understanding. Is the image used by the Serverless operator on server side? Isn't it something like e.g. our must-gather image which we produce but it's not mentioned in CSV because users will call it directly (on client side)?

@cardil
Copy link
Copy Markdown
Member Author

cardil commented Dec 13, 2021

When users will call kn event send --to giving some cluster local resource (like broker, channel or kservice), a K8s job will be created with this image.

It needs to be in CSV, in relatedImages section, to gets mirrored. So, the disconnected clusters will work as well.

/cc @rhuss

@openshift-ci openshift-ci bot requested a review from rhuss December 13, 2021 15:18
@cardil
Copy link
Copy Markdown
Member Author

cardil commented Dec 13, 2021

At @Kaustubh-pande: As you can see, the CSV generation mechanics in Serverless operator adds IMAGE_ to the front of the name of the image. In other places we have the same name but with _IMAGE as suffix instead.

WDYT of changing it in other places to this naming. In places like: https://github.com/openshift/knative-client/blob/f2b87473f6c69f413a2de69efeef82d51bf3c474/hack/build.sh.d/kn-plugin-event.sh#L7

@cardil
Copy link
Copy Markdown
Member Author

cardil commented Dec 13, 2021

/hold

Until image is available

@cardil
Copy link
Copy Markdown
Member Author

cardil commented Dec 13, 2021

After changes in openshift/release#24549 images was promoted properly:

$ skopeo inspect docker://registry.ci.openshift.org/knative/release-0.26:client-plugin-event-sender \
  | jq -r .Digest
sha256:4da4400a0c74d6d0fdd65d527c21bf5af187aa84d30de6d2dd593042fc1b7599

/unhold

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Dec 14, 2021

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c391d70 into openshift-knative:main Dec 14, 2021
@cardil cardil deleted the feature/kn-event-sender-image branch December 14, 2021 10:41
cardil added a commit to cardil/knative-client that referenced this pull request Dec 14, 2021
Align the default sender image to one promoted by OpenShift CI.

This aligns defaults with openshift-knative/serverless-operator#1337

Further refs.:

 - openshift/release#24476
 - openshift/release#24549
openshift-merge-robot pushed a commit to openshift/knative-client that referenced this pull request Dec 14, 2021
Align the default sender image to one promoted by OpenShift CI.

This aligns defaults with openshift-knative/serverless-operator#1337

Further refs.:

 - openshift/release#24476
 - openshift/release#24549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants