Skip to content

Allow openshift-serverless namespace to pull images from openshift-marketplace #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Aug 1, 2022
Merged

Allow openshift-serverless namespace to pull images from openshift-marketplace #1663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hack/lib/catalogsource.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ function install_catalogsource {
# Allow OPM to pull the serverless-bundle from openshift-marketplace ns from internal registry.
oc adm policy add-role-to-group system:image-puller system:unauthenticated --namespace openshift-marketplace

# export ON_CLUSTER_BUILDS=true; make images
# will push images to ${OLM_NAMESPACE} namespace, allow the ${OPERATORS_NAMESPACE} namespace to pull those images.
oc adm policy add-role-to-group system:image-puller system:serviceaccounts:"${OPERATORS_NAMESPACE}" --namespace "${OLM_NAMESPACE}"

Comment on lines 53 to +59
Copy link
Copy Markdown
Member Author

@pierDipi pierDipi Aug 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other option might be:

oc adm policy add-role-to-group system:image-puller system:authenticated --namespace openshift-marketplace

but given the TODO above, I went with more minimal permissions possible without requiring to list every service account that would require keeping the list updated.

local index_build_dir=${rootdir}/olm-catalog/serverless-operator/index

logger.debug "Create a backup of the index Dockerfile."
Expand Down