Skip to content

[RELEASE-1.25][SRVCOM-2106] Remove seccomprofile from CSV deployments#1723

Merged
matzew merged 1 commit into
openshift-knative:release-1.25from
skonto:fix_csv_sc
Sep 22, 2022
Merged

[RELEASE-1.25][SRVCOM-2106] Remove seccomprofile from CSV deployments#1723
matzew merged 1 commit into
openshift-knative:release-1.25from
skonto:fix_csv_sc

Conversation

@skonto
Copy link
Copy Markdown
Collaborator

@skonto skonto commented Sep 21, 2022

@skonto skonto requested review from maschmid and pierDipi September 21, 2022 12:20
@openshift-ci openshift-ci Bot requested review from lberk and rhuss September 21, 2022 12:20
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 21, 2022

/hold for testing on 4.10. We should add a 4.7+ ci job.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 21, 2022

Works on 4.10:

$ oc get pods -n openshift-serverless
NAME                                         READY   STATUS    RESTARTS   AGE
knative-openshift-55bf9f78f4-9tf64           1/1     Running   0          13m
knative-openshift-ingress-5fc448d467-zfzg2   1/1     Running   0          13m
knative-operator-78f65f74bd-2s4pg            1/1     Running   0          13m
$ oc get csv -n openshift-serverless
NAME                               DISPLAY                                                 VERSION    REPLACES                      PHASE
jaeger-operator.v1.36.0-2          Red Hat OpenShift distributed tracing platform          1.36.0-2   jaeger-operator.v1.34.1-5     Succeeded
opentelemetry-operator.v0.56.0-1   Red Hat OpenShift distributed tracing data collection   0.56.0-1                                 Succeeded
serverless-operator.v1.25.0        Red Hat OpenShift Serverless                            1.25.0     serverless-operator.v1.24.0   Succeeded
$ oc version
Client Version: 4.10.0-202205311508.p0.g878f5a8.assembly.stream-878f5a8
Server Version: 4.10.33
Kubernetes Version: v1.23.5+012e945

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 21, 2022

/unhold

@skonto skonto changed the title [RELEASE-1.25][SRVCOM-2106] Remove seccomprofile [RELEASE-1.25][SRVCOM-2106] Remove seccomprofile from CSV deployments Sep 21, 2022
@maschmid
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Sep 21, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 21, 2022

/test 4.6-upgrade-tests-aws-ocp-46

@pierDipi
Copy link
Copy Markdown
Member

/retest

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD cf13844 and 2 for PR HEAD 589809c in total

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 21, 2022

This keeps coming up, upgrade tests failed @matzew probably need to do it manually again 🤷 :

3/262 Tests Failed. | expand_less
-- | --
test/upgrade: TestServerlessUpgrade/VerifyContinualTests/KafkaBrokerContinualTest expand_less16s{Failed  === RUN   TestServerlessUpgrade/VerifyContinualTests/KafkaBrokerContinualTest 2022-09-21T19:52:31.701Z	INFO	upgrade/steps.go:116	8.6) Verifying "KafkaBrokerContinualTest". | test/upgrade: TestServerlessUpgrade/VerifyContinualTests/KafkaBrokerContinualTest expand_less | 16s | {Failed  === RUN   TestServerlessUpgrade/VerifyContinualTests/KafkaBrokerContinualTest 2022-09-21T19:52:31.701Z	INFO	upgrade/steps.go:116	8.6) Verifying "KafkaBrokerContinualTest".
test/upgrade: TestServerlessUpgrade/VerifyContinualTests/KafkaBrokerContinualTest expand_less | 16s
{Failed  === RUN   TestServerlessUpgrade/VerifyContinualTests/KafkaBrokerContinualTest 2022-09-21T19:52:31.701Z	INFO	upgrade/steps.go:116	8.6) Verifying "KafkaBrokerContinualTest".

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 21, 2022

/test 4.6-upgrade-tests-aws-ocp-46

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 21, 2022

/retest

@matzew
Copy link
Copy Markdown
Member

matzew commented Sep 22, 2022

/test 4.6-upgrade-tests-aws-ocp-46

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 22, 2022

@matzew This is misbehaving:

12s
--
{Failed  === RUN   TestServerlessUpgrade/VerifyContinualTests/KafkaSinkSourceContinualTest

Is this a known issue? Should we merge?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 22, 2022

@skonto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.6-upgrade-tests-aws-ocp-46 589809c link true /test 4.6-upgrade-tests-aws-ocp-46

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 22, 2022

@matzew can we merge? I restarted the job but it takes ~1.5h and Kafka failure happened twice the last few times.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 22, 2022

/retest

@matzew matzew merged commit 7c56961 into openshift-knative:release-1.25 Sep 22, 2022
@matzew
Copy link
Copy Markdown
Member

matzew commented Sep 22, 2022

OK, doing this for now...

openshift-merge-robot pushed a commit that referenced this pull request Oct 26, 2022
* [RELEASE-1.25][SRVCOM-1857] Upgrade unavailable/deprecated K8s APIs (#1710)

* upgrade from deprecated apis

* psec

* fix rbac proxy

* remove seccomprofile (#1723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants