Skip to content

Bump Serving to v1.5#1732

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:mainfrom
skonto:bump_serving_1.5
Sep 27, 2022
Merged

Bump Serving to v1.5#1732
openshift-merge-robot merged 1 commit into
openshift-knative:mainfrom
skonto:bump_serving_1.5

Conversation

@skonto
Copy link
Copy Markdown
Collaborator

@skonto skonto commented Sep 25, 2022

Proposed Changes

@openshift-ci openshift-ci Bot requested review from aliok and jcrossley3 September 25, 2022 19:45
@skonto skonto changed the title Bump Serving to v1.5 [wip]Bump Serving to v1.5 Sep 25, 2022
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 25, 2022

/retest

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 26, 2022

ci/prow/4.11-upgrade-tests-aws-ocp-411

{"level":"error","ts":"2022-09-25T21:56:55.098Z","logger":"knative-operator","caller":"knativeserving/reconciler.go:294","msg":"Returned an error","knative.dev/pod":"knative-operator-79657bc6b5-nr5kz","knative.dev/controller":"knative.dev.operator.pkg.reconciler.knativeserving.Reconciler","knative.dev/kind":"operator.knative.dev.KnativeServing","knative.dev/traceid":"9afd61b1-3007-47d7-a66d-7e3e00f05078","knative.dev/key":"knative-serving/knative-serving","targetMethod":"ReconcileKind","error":"failed to apply non rbac manifest: admission webhook "config.webhook.serving.knative.dev" denied the request: validation failed: the update modifies a key in "_example" which is probably not what you want. Instead, copy the respective setting to the top-level of the ConfigMap, directly below "data"","stacktrace":"knative.dev/operator/pkg/client/injection/reconciler/operator/v1alpha1/knativeserving.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 26, 2022

/test 4.11-operator-e2e-aws-ocp-411

@skonto skonto requested a review from nak3 September 26, 2022 09:08
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 26, 2022

ci/prow/4.11-operator-e2e-aws-ocp-411:

10:03:10.140 DEBUG:   [[ $(oc get pods -n knative-serving --field-selector=status.phase!=Succeeded -o jsonpath='{.items}') != '[]' ]] : Waiting until non-zero (max 600 sec.)
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
10:13:54.998 ERROR:   Time out of 600 exceeded

@skonto skonto changed the title [wip]Bump Serving to v1.5 Bump Serving to v1.5 Sep 26, 2022
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 26, 2022

/hold for fixes

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 26, 2022

Run the operator tests locally against a 4.11 cluster. They run fine. 🤔 why they time out on the CI, @mgencur seen this before?

./hack/teardown.sh
DEBUG   14:56:44.048 Debug log (set -x) is written to: /tmp/tmp.OGsaOTCnZS/debuglog-teardown.sh.log
DEBUG   14:56:44.050 Registering error handler: stacktrace
WARNING 14:56:44.052 😭  Teardown Serverless...
INFO    14:56:46.618 Removing KnativeServing CR
knativeserving.operator.knative.dev "knative-serving" deleted
INFO    14:57:00.130 Ensure no knative serving pods running
DEBUG   14:57:00.138 [[ $(oc get pods -n knative-serving --field-selector=status.phase!=Succeeded -o jsonpath='{.items}') != '[]' ]] : Waiting until non-zero (max 600 sec.) ...................... done
namespace "knative-serving" deleted
INFO    14:57:57.501 Ensure no ingress pods running
DEBUG   14:57:57.509 [[ $(oc get pods -n knative-serving-ingress --field-selector=status.phase!=Succeeded -o jsonpath='{.items}') != '[]' ]] : Waiting until non-zero (max 600 sec.) done
DEBUG   14:57:58.291 [[ $(oc get ns knative-serving-ingress --no-headers | wc -l) == 1 ]] : Waiting until non-zero (max 600 sec.) done
INFO    14:58:01.760 Removing KnativeEventing CR
knativeeventing.operator.knative.dev "knative-eventing" deleted
INFO    14:58:27.781 Ensure no knative eventing or knative kafka pods running
DEBUG   14:58:27.783 [[ $(oc get pods -n knative-eventing --field-selector=status.phase!=Succeeded -o jsonpath='{.items}') != '[]' ]] : Waiting until non-zero (max 700 sec.) ........... done
namespace "knative-eventing" deleted


@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 26, 2022

/test 4.11-operator-e2e-aws-ocp-411

@skonto skonto changed the title Bump Serving to v1.5 [wip] Bump Serving to v1.5 Sep 26, 2022
Comment thread hack/lib/serverless.bash Outdated
fi
logger.info 'Ensure no knative serving pods running'
timeout 600 "[[ \$(oc get pods -n ${SERVING_NAMESPACE} --field-selector=status.phase!=Succeeded -o jsonpath='{.items}') != '[]' ]]"
timeout 900 "[[ \$(oc get pods -n ${SERVING_NAMESPACE} --field-selector=status.phase!=Succeeded -o jsonpath='{.items}') != '[]' ]]"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing to see if this is ever deleted.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 26, 2022

Ok found the issue with upgrade tests we need quay promotion because during upgrades we test with that instead:

[migrate]","reason":"ContainersNotReady","status":"False","type":"ContainersReady"},{"lastProbeTime":null,"lastTransitionTime":"2022-09-26T15:39:18Z","status":"True","type":"PodScheduled"}],"containerStatuses":[{"image":"quay.io/openshift-knative/knative-serving-storage-version-migration:v1.5.0","imageID":"","lastState":{},"name":"migrate","ready":false,"restartCount":0,"started":false,"state":{"waiting":{"message":"Back-off pulling image "quay.io/openshift-knative/knative-serving-storage-version-migration:v1.5.0"","reason":"ImagePullBackOff"}}}],"hostIP":"10.0.128.38","phase":"Pending","podIP":"10.129.2.16","podIPs":[{"ip":"10.129.2.16"}],"qosClass":"Burstable","startTime":"2022-09-26T15:39:18Z"}}] != [] ]]

  • seconds=899

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 26, 2022

/assign @nak3 @mgencur

@skonto skonto changed the title [wip] Bump Serving to v1.5 Bump Serving to v1.5 Sep 26, 2022
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 26, 2022

infra

Total download size: 95 M
Downloading packages:
No Presto metadata available for updates
https://rpm.nodesource.com/pub_14.x/el/7/x86_64/nodejs-14.18.0-1nodesource.x86_64.rpm: [Errno 14] curl#18 - "transfer closed with 2247078 bytes remaining to read"
Trying other mirror.
Error downloading packages:
2:nodejs-14.18.0-1nodesource.x86_64: [Errno 256] No more mirrors to try.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 26, 2022

/retest

1 similar comment
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 27, 2022

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2022

@skonto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upstream-e2e-kafka-aws-ocp-411 829069f link false /test 4.11-upstream-e2e-kafka-aws-ocp-411

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 27, 2022

@pierDipi is 4.11-upstream-e2e-kafka-aws-ocp-411 wip?

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi is 4.11-upstream-e2e-kafka-aws-ocp-411 wip?

yes, please ignore

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Sep 27, 2022

@pierDipi or @mgencur or @nak3 want to review/stamp this one? 🙏

@nak3
Copy link
Copy Markdown
Contributor

nak3 commented Sep 27, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Sep 27, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 697d4c6 into openshift-knative:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants