Skip to content

Define default BROKER_CLASS#1811

Merged
matzew merged 1 commit into
openshift-knative:mainfrom
pierDipi:cp-7edb0ac45-main
Nov 17, 2022
Merged

Define default BROKER_CLASS#1811
matzew merged 1 commit into
openshift-knative:mainfrom
pierDipi:cp-7edb0ac45-main

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Nov 16, 2022 •
edited
Loading

Test failing with:

            --- FAIL: TestServerlessUpgrade/PreUpgradeTests/BrokerPreUpgradeTest/1 (2.86s)
panic: error getting KafkaBroker class from env 'unable to determine KafkaBroker class. Specify 'BROKER_CLASS' env var' [recovered]
	panic: error getting KafkaBroker class from env 'unable to determine KafkaBroker class. Specify 'BROKER_CLASS' env var'

@pierDipi
Define default BROKER_CLASS
61ecbca 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci openshift-ci Bot requested review from lberk and nak3 November 16, 2022 11:19
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Nov 16, 2022

/test 4.11-osd-images

@pierDipi pierDipi changed the title [WIP] Define default BROKER_CLASS Define default BROKER_CLASS Nov 16, 2022
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Nov 16, 2022

/retest-required

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Nov 16, 2022

/cc @matzew

@openshift-ci openshift-ci Bot requested a review from matzew November 16, 2022 12:59
matzew
matzew approved these changes Nov 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Nov 16, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Nov 16, 2022

/retest-required

@matzew
Copy link
Copy Markdown
Member

matzew commented Nov 17, 2022

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 17, 2022

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-tests-aws-ocp-411 61ecbca link false /test 4.11-upgrade-tests-aws-ocp-411
ci/prow/4.11-operator-e2e-aws-ocp-411 61ecbca link true /test 4.11-operator-e2e-aws-ocp-411

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@matzew matzew merged commit eae7141 into openshift-knative:main Nov 17, 2022
@pierDipi pierDipi deleted the cp-7edb0ac45-main branch November 17, 2022 08:13
@skonto skonto mentioned this pull request Nov 17, 2022
Merged
@pierDipi pierDipi restored the cp-7edb0ac45-main branch February 19, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@lberk lberk Awaiting requested review from lberk

@nak3 nak3 Awaiting requested review from nak3

Assignees

@matzew matzew

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pierDipi @matzew