Enable multi-arch support in operator#363
Enable multi-arch support in operator#363yselkowitz wants to merge 1 commit intoopenshift-knative:mainfrom
Conversation
|
Hi @yselkowitz. Thanks for your PR. I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @navidshaikh @rhuss |
|
@nak3: GitHub didn't allow me to assign the following users: navidshaikh, rhuss. Note that only openshift-knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| consolev1.Link{ | ||
| Text: "Download kn for Linux for IBM Power little endian", | ||
| Href: baseURL + "/ppc64le/linux/kn-linux-ppc64le.tar.gz", | ||
| }, | ||
| consolev1.Link{ | ||
| Text: "Download kn for Linux for IBM Z", | ||
| Href: baseURL + "/s390x/linux/kn-linux-s390x.tar.gz", | ||
| }, | ||
| consolev1.Link{ | ||
| Text: "Download kn for Linux for ARM 64", | ||
| Href: baseURL + "/arm64/linux/kn-linux-arm64.tar.gz", | ||
| }, |
There was a problem hiding this comment.
Respective PR to add these new paths in cli-artifacts image is open, lets test this once the other PR is in.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yselkowitz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@navidshaikh @rhuss is this still needed ? |
|
@matzew : nope, we are yet to plan the target release for enabling these architectures. |
yselkowitz
changed the title
yselkowitz
force-pushed
the
master
branch
2 times, most recently
from
ce2138e to
7ed6953
Compare
|
knative-client PRs have merged, so this can go in now. |
|
IIUC, we're enabling the builds for mentioned architecture, the change-set in this PR publishes it for end consumers. This step needs to happen after we get ack from test teams ? cc @warrenvw |
|
Closing in favour of #840 |
5 participants
Filing here now based on feedback in openshift/knative-client#411, but this depends on the multi-arch binaries landing in kn-cli-artifacts via openshift/knative-client#414 and possibly other follow-up work.
If there is something else missing on the operator side, please let me know.
/hold