Skip to content

Conversation

@nak3
Copy link

@nak3 nak3 commented Mar 3, 2023

This patch seds s/all/ALL/g for autoscaler-hpa deployments, which missed in #14.

/cc @skonto @ReToCode

@openshift-ci openshift-ci bot requested review from ReToCode and skonto March 3, 2023 02:08
@openshift-ci openshift-ci bot added the approved label Mar 3, 2023
@nak3
Copy link
Author

nak3 commented Mar 3, 2023

With said, release-1.6 branch also missed this in #12 💦 @skonto Should we fix it in release-1.6 as well?

@nak3
Copy link
Author

nak3 commented Mar 3, 2023

/hold

Wait for the response about https://redhat-internal.slack.com/archives/CF5ANN61F/p1677811505789239

@ReToCode
Copy link

ReToCode commented Mar 3, 2023

/lgtm
/approve

👍 to back-port to 1.6 for consistency.

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link

skonto commented Mar 3, 2023

Fyi we cover this anyway at the S-O side.

@nak3
Copy link
Author

nak3 commented Mar 3, 2023

Oh, it has a transformer. Then, #12 was also uncessary 🤔
Anyway clsoing here.

@nak3 nak3 closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants