Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #131

/assign ReToCode

)

* Don't default Revision values when BYO name is unchanged.

Fixes knative#11512

* Switch to using a context-passed ConfigurationSpec reference instead of hard-coding Configuration and Service.

* Complete docstring for WithConfigurationSpec

* Update naming per dave's feedback
@openshift-ci openshift-ci bot requested review from nak3 and skonto March 8, 2023 08:51
@ReToCode ReToCode changed the title [release-v1.8] [RELEASE-1.7][BACKPORT] Don't default Revision values when BYO name is unchanged. [release-v1.8][BACKPORT] Don't default Revision values when BYO name is unchanged. Mar 8, 2023
@ReToCode
Copy link

ReToCode commented Mar 8, 2023

/cc @skonto , @nak3 #131 (comment)

@skonto
Copy link

skonto commented Mar 9, 2023

@ReToCode @nak3 yes let's add this for consistency for 1.8 (but not for 1.9+).

So in 1.7 we added this because when we have sec pod defaults on and we do an upgrade (1.6 -> 1.7) revisions are modified during defaulting. Thus the BYO (bring your own) name services dont fail.
The BYO name service requires you to change the name of the revision manually if you do an update to its spec and without this an update happens and test fail. The normal services update the revision name automatically by adding a suffix (if the change requires a new revision). Revisions are immutable.

For 1.8 I suspect user will be on 1.7 anyway so things will not fail but let's have it to avoid any inconsistencies.

@ReToCode
Copy link

For 1.8 I suspect user will be on 1.7 anyway so things will not fail but let's have it to avoid any inconsistencies.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Mar 10, 2023
@nak3
Copy link

nak3 commented Mar 10, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, openshift-cherrypick-robot, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bd52068 into openshift-knative:release-v1.8 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants