Skip to content

Conversation

@skonto
Copy link

@skonto skonto commented Apr 25, 2023

What this PR does / why we need it:

Backport that fixes some webhook issues.

Which issue(s) this PR fixes:

JIRA: SRVKS-1046

Does this PR needs for other branches:

/cherry-pick release-v1.9

Does this PR (patch) needs to update/drop in the future?:

NONE

* probe fixes

* fixes

* fix threshold

* cleanup
@skonto skonto requested review from ReToCode and nak3 April 25, 2023 10:07
@openshift-ci openshift-ci bot requested a review from mvinkler April 25, 2023 10:07
@skonto skonto removed the request for review from mvinkler April 25, 2023 10:08
@skonto skonto changed the title [SRVKS-1046] Deployment probe fixes [RELEASE-18] [SRVKS-1046] Deployment probe fixes Apr 25, 2023
Copy link

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a234d97 into openshift-knative:release-v1.8 Apr 25, 2023
@ReToCode
Copy link

/cherry-pick release-v1.9

@openshift-cherrypick-robot

@ReToCode: new pull request created: #293

Details

In response to this:

/cherry-pick release-v1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants