Skip to content

Conversation

@nak3
Copy link

@nak3 nak3 commented Nov 24, 2022

/cc

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

@nak3: GitHub didn't allow me to request PR reviews from the following users: nak3.

Note that only openshift-knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3
Copy link
Author

nak3 commented Nov 24, 2022

Hmm... The operator image is 1.26.0 not nigthly build. So the patch cannot be dropped until next release cut 1.27

    Container ID:   cri-o://2f22d4f4c9a8936e4122046a797718ee82ad0a74cf2e5a193300e1df1571da7f
    Image:          registry.ci.openshift.org/knative/openshift-serverless-v1.26.0:knative-operator
    Image ID:       registry.ci.openshift.org/knative/openshift-serverless-v1.26.0@sha256:5cea55dd8746482291a5ba032e5b5f6f65bdf3dc109288998fd41744d7876fb4

@nak3
Copy link
Author

nak3 commented Dec 1, 2022

Once openshift-knative/serverless-operator#1797 was merged, we can drop it I think.

@nak3 nak3 reopened this Dec 2, 2022
@nak3 nak3 mentioned this pull request Dec 2, 2022
@nak3 nak3 closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants