Skip to content

Conversation

@ReToCode
Copy link

@ReToCode ReToCode commented Oct 2, 2023

What this PR does / why we need it:

  • Sync with upstream release-1.10
  • Basically no differences, but as the secure-pod-defaults were back-ported upstream, so we also need

here if we want to be able to run https://github.com/openshift-knative/serving/actions/runs/6377668928 in the future

knative-prow-robot and others added 6 commits May 9, 2023 02:27
…native#13963)

quay.io only supports 1.2

Co-authored-by: dprotaso <dprotaso@gmail.com>
this prevents nodes from draining

Co-authored-by: dprotaso <dprotaso@gmail.com>
… targets is 2 (with equal weight) (knative#14052)

* RandomChoice 2 policy wasn't random when the number of targets is 2

* fix linting

---------

Co-authored-by: dprotaso <dprotaso@gmail.com>
…ainer and queue-proxy) (knative#14377)

* add seccompProfile to queue container security context

* run as non root by default

* update tests to expect new default run as nonroot

* fix perms

---------

Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
@ReToCode
Copy link
Author

ReToCode commented Oct 2, 2023

/assign @nak3
/assign @skonto

@openshift-ci openshift-ci bot assigned nak3 and skonto Oct 2, 2023
@openshift-ci openshift-ci bot requested review from mvinkler and nak3 October 2, 2023 09:08
@openshift-ci openshift-ci bot added the approved label Oct 2, 2023
@nak3
Copy link

nak3 commented Oct 2, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 08434db and 2 for PR HEAD fdbdc3e in total

@skonto
Copy link

skonto commented Oct 2, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit c13b18d into openshift-knative:release-v1.10 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants