Skip to content

[release-1.11] PodAutoscaler Active Condition should not affect Reachability (#14309)#515

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-knative:release-v1.11from
ReToCode:backport-14309
Nov 6, 2023
Merged

[release-1.11] PodAutoscaler Active Condition should not affect Reachability (#14309)#515
openshift-merge-bot[bot] merged 1 commit intoopenshift-knative:release-v1.11from
ReToCode:backport-14309

Conversation

@ReToCode
Copy link
Copy Markdown

@ReToCode ReToCode commented Nov 6, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

JIRA: https://issues.redhat.com/browse/SRVKS-1175

Does this PR needs for other branches:
No, it is included from 1.12

Does this PR (patch) needs to update/drop in the future?:
No

…e#14309)

* Don't change reachability if the PA is not active

* drop unused helper method

(cherry picked from commit 9ffab17)
@openshift-ci openshift-ci bot requested review from alanfx and mgencur November 6, 2023 08:08
@ReToCode
Copy link
Copy Markdown
Author

ReToCode commented Nov 6, 2023

/assign @nak3
/assign @skonto

@nak3
Copy link
Copy Markdown

nak3 commented Nov 6, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Nov 6, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 316995a into openshift-knative:release-v1.11 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants