[SRVKS-211] Add gRPC test work against OpenShift Routes #55
Conversation
openshift/e2e-common.sh
Outdated
| oc annotate ingresses.config/cluster ingress.operator.openshift.io/default-enable-http2=true | ||
| oc annotate knativeserving knative-serving -n knative-serving serverless.openshift.io/default-enable-http2=true | ||
|
|
||
| # This is not necessary actually but it makes usre that access passes through OCP route. |
| -n "${SERVING_NAMESPACE}" \ | ||
| --type merge --patch '{"spec": {"ingress": {"kourier": {"service-type": "ClusterIP"}}}}' | ||
|
|
||
| if [[ $(oc get infrastructure cluster -ojsonpath='{.status.platform}') = VSphere ]]; then |
There was a problem hiding this comment.
Why VSphere is different could you elaborate a bit?
There was a problem hiding this comment.
Because of the line above
serving/openshift/e2e-common.sh
Lines 346 to 350 in 806c070
It is not introduced by this commit by this for a long time ago - openshift#490
I am not a person who made it but I guess VSphere is not cloud but sort of bare metal server so it does not work with ExternalIP service so we need to make it different.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v1.8 |
|
@nak3: new pull request created: #58 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-v1.7 |
|
/cherry-pick release-v1.6 |
|
@nak3: new pull request created: #59 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nak3: new pull request created: #60 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This patch runs gRPC test against OCP Route.
When enabling HTTP2 on OCP route by
oc annotate ingresses.config/cluster ingress.operator.openshift.io/default-enable-http2=true, websocket does not work due to OCP Route(HAProxy)'s limitation.So the test is executed separately.