Skip to content

Conversation

@nak3
Copy link

@nak3 nak3 commented Dec 6, 2022

As per title, this patch adds the patch knative-extensions/control-protocol@4472b31

@openshift-ci openshift-ci bot requested review from mgencur and mvinkler December 6, 2022 01:24
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 6, 2022
@nak3 nak3 changed the title [SRVKS-971][RELEASE-v1.6] Apply common name patch [RELEASE-v1.6][SRVKS-971] Apply common name patch Dec 6, 2022
@nak3
Copy link
Author

nak3 commented Dec 6, 2022

/hold

This does not meet the timeline for 1.26. I will send the fix against 1.7.

@skonto
Copy link

skonto commented Dec 8, 2022

@nak3 1.6 is for 1.27 we have until next week why it does not meet the dealine?

@nak3
Copy link
Author

nak3 commented Dec 8, 2022

/hold cancel
Ah, sorry. I wrongly counted the number. It meets the deadline then.

@nak3
Copy link
Author

nak3 commented Dec 8, 2022

Closing as cherry-picked by #72

@nak3 nak3 closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants