This repository was archived by the owner on Mar 23, 2020. It is now read-only.
cnv: fixes issue #18#33
Closed
karmab wants to merge 1 commit intoopenshift-kni:masterfrom
karmab:cnv
Closed
Conversation
Contributor
|
Is this for issue #18? If so, can you update the PR description and commit message to reference the issue? |
markmc
reviewed
Aug 19, 2019
Contributor
|
I think it would be better to have a single
|
Contributor
Author
agreed, so i left the bridge script as an optional step that one might want to launch when deploying CNV rather than during post install |
Contributor
|
I believe this PR can be closed as the good one seems to be #42 |
Collaborator
|
@karmab - any issue with closing this? |
Contributor
|
ping @karmab |
Collaborator
|
ping @karmab - Should this be closed? |
Contributor
Author
|
yes let s close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #18
this is currently done without nmstate