This repository was archived by the owner on Mar 23, 2020. It is now read-only.
Add Makefiles to CNV and OCS directories#43
Closed
johnbieren wants to merge 1 commit intoopenshift-kni:masterfrom
Closed
Add Makefiles to CNV and OCS directories#43johnbieren wants to merge 1 commit intoopenshift-kni:masterfrom
johnbieren wants to merge 1 commit intoopenshift-kni:masterfrom
Conversation
Signed-off-by: Johnny Bieren <jbieren@redhat.com>
Contributor
Author
|
@rlopez133 I don't seem to be able to add reviewers, but if you could take a look at this one when you have a chance as well, I'd appreciate it |
Collaborator
|
@johnbieren |
Contributor
Author
|
Going to reopen and rebase once #42 lands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is much easier from a CI perspective to have common make targets to call to deploy the various components of the appliance. Otherwise, changes to script names (such as the PR to add CNV-2.1) would break CI
This is following a similar mindset to #41
Signed-off-by: Johnny Bieren jbieren@redhat.com