This repository was archived by the owner on Mar 23, 2020. It is now read-only.
Moved OCP post install where it belongs#48
Merged
sreichar merged 1 commit intoopenshift-kni:masterfrom Aug 29, 2019
e-minguez:move_postinstall_to_ocp
Merged
Moved OCP post install where it belongs#48sreichar merged 1 commit intoopenshift-kni:masterfrom e-minguez:move_postinstall_to_ocp
sreichar merged 1 commit intoopenshift-kni:masterfrom
e-minguez:move_postinstall_to_ocp
Conversation
sreichar
reviewed
Aug 29, 2019
| post_install: | ||
| ./99_post_install.sh | ||
|
|
||
| clean: host_cleanup |
Collaborator
There was a problem hiding this comment.
Should post install be added to default?
Contributor
Author
There was a problem hiding this comment.
I'd say to keep it 'manual' yet until something else is needed because the bridge seems to be handled by #47
Collaborator
There was a problem hiding this comment.
After #50 merges, I think we should plumb this to the top level also.
sreichar
approved these changes
Aug 29, 2019
Collaborator
sreichar
left a comment
sreichar
left a comment
There was a problem hiding this comment.
nothing beyond the mentioned future work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.