Skip to content

Revert "Add unit to time in "podman wait" command." #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtantsur wants to merge 1 commit into from
Closed

Revert "Add unit to time in "podman wait" command." #1150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 04_setup_ironic.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ then
sudo podman run -d --net host --privileged --name ipa-downloader --pod ironic-pod \
-v $IRONIC_DATA_DIR:/shared ${IRONIC_IPA_DOWNLOADER_LOCAL_IMAGE} /usr/local/bin/get-resource.sh

sudo podman wait -i 1000ms ipa-downloader
sudo podman wait -i 1000 ipa-downloader
Copy link
Copy Markdown

@hardys hardys Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it seems there's no format currently which works for both centos and RHEL, would you mind putting a conditional here please?

I guess checking the podman version is safest since it's probably only a matter of time before centos picks up the newer podman with the required unit (until the bz mentioned by Stephen is fixed)

fi

function is_running() {
Expand Down