Skip to content

Set bootstrap provisioning ip only when the openshift version is < 4.7#1156

Merged
openshift-merge-robot merged 1 commit intoopenshift-metal3:masterfrom
asalkeld:set-bootstrapProvIp-per-version
Dec 3, 2020
Merged

Set bootstrap provisioning ip only when the openshift version is < 4.7#1156
openshift-merge-robot merged 1 commit intoopenshift-metal3:masterfrom
asalkeld:set-bootstrapProvIp-per-version

Conversation

@asalkeld
Copy link
Copy Markdown
Contributor

@asalkeld asalkeld commented Nov 19, 2020

This builds on top of @hardys #1146
and depends on openshift/installer#4390

@asalkeld asalkeld mentioned this pull request Nov 19, 2020
Merged
@openshift-merge-robot
Copy link
Copy Markdown

openshift-merge-robot commented Nov 20, 2020

@asalkeld: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 37ed8b0 link /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hardys
hardys reviewed Nov 24, 2020
View reviewed changes
Comment thread ocp_install_env.sh
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 26, 2020
@asalkeld asalkeld requested a review from hardys December 1, 2020 01:43
@stbenjam
Copy link
Copy Markdown
Member

stbenjam commented Dec 2, 2020

/test e2e-metal-ipi-virtualmedia

Let's test the disabled code path

@stbenjam
Copy link
Copy Markdown
Member

stbenjam commented Dec 2, 2020

/approve

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@stbenjam
Copy link
Copy Markdown
Member

stbenjam commented Dec 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 482cde6 into openshift-metal3:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stbenjam stbenjam Awaiting requested review from stbenjam

@zaneb zaneb Awaiting requested review from zaneb

@hardys hardys Awaiting requested review from hardys

Assignees

@stbenjam stbenjam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asalkeld @openshift-merge-robot @stbenjam @openshift-ci-robot @hardys