Fix error building images without extra pkgs

[cybertron]

The extra pkg change broke image builds that don't use it because
it was unconditionally calling realpath on the variable. If it wasn't
set then this resulted in an invalid command. To fix this we just
need to move the realpath call inside the -n check so we only do it
if the variable is populated.

[hardys]

/test e2e-metal-ipi
/approve
/cc @elfosardo

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hardys]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hardys]

Any idea why CI on #1142 didn't catch this?

Edit: I guess it's because the set -e on the script doesn't catch the subshell error, so you only noticed this by looking at the logs vs the parent script failing?

[elfosardo]

/lgtm

[elfosardo]

Any idea why CI on #1142 didn't catch this?

Edit: I guess it's because the set -e on the script doesn't catch the subshell error, so you only noticed this by looking at the logs vs the parent script failing?

that's probably it, I still need to move the build images code to a separate script as done for the base image, that should help catching future errors

[cybertron]

A dev-scripts patch doesn't build any images so it wouldn't have hit this code path. I believe set -e should catch errors from a subshell.