Add ability to inject static ips into install-config by imain · Pull Request #1297 · openshift-metal3/dev-scripts

imain · 2021-10-04T21:28:00Z

Set up a STATIC_IPS configuration flag that configures dev-scripts
to use static IPs (v4 and/or v6) for the baremetal network.

Co-Authored-By: Caleb Boylan cboylan@redhat.com

openshift-ci · 2021-10-04T21:28:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hardys after the PR has been reviewed.
You can assign the PR to them by writing /assign @hardys in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

imain · 2021-10-04T21:29:41Z

Requires metal3-io/metal3-dev-env#820

Same comment applies here. We could plumb this with a new vm_setup_vars.yaml that sets up a static IP configuration for the network. That may be a better approach. Let me know.

bfournie · 2021-12-16T22:10:02Z

/retest

hardys · 2021-12-20T16:19:55Z

  # Note we only do this in the case where METAL3_DEV_ENV is
  # unset, to enable developer testing of local checkouts
-  git reset ee1b2fec44e22700c8d250d5e0e371e3fd0aba17 --hard
+  #git reset 67afcb3315b44e2c68121493a819819966e588a2 --hard


This needs to be removed - note you can use METAL3_DEV_ENV to reference a local source checkout for testing with latest metal3-dev-env :)

hardys · 2021-12-20T16:21:27Z

 fi

-if [[ "$PROVISIONING_NETWORK_PROFILE" == "Disabled" ]]; then
+if [[ "$PROVISIONING_NETWORK_PROFILE" == "Disabled" || -n "$STATIC_IPS" ]]; then


I think we should support both virtualmedia and PXE paths now?

hardys · 2021-12-20T16:24:21Z

    bridge: "{{ provisioning_network_name  }}"
    forward_mode: bridge

+virsh_dhcp_enabled: "{{ lookup('env', 'DHCP_ENABLED')|default('', true) }}"


I don't think we need this, since the environment variable is already respected in the defaults ref metal3-io/metal3-dev-env#879 ?

derekhiggins · 2021-12-21T11:20:01Z

+            config:
+            - destination: 0.0.0.0/0
+              next-hop-address: ${PROVISIONING_HOST_EXTERNAL_IP}
+              next-hop-interface: ${PROVISIONING_NETWORK_INTERFACE}


We normally would have the default route on the External network, is the change to the provisioning network intentional?

hardys · 2022-01-05T09:44:49Z

@imain any updates on this? It'd be useful to get this done so we can attempt reproduces for bugs (for example https://bugzilla.redhat.com/show_bug.cgi?id=2036677) - I think other than the comments already added, we'll also need to inject static configuration for the bootstrap VM?

It'd be great to either create a new periodic CI job too based on this work, or switch the config of one of the existing ones to provide coverage.

hardys · 2022-01-05T09:45:56Z

Note there are also a couple of comments on metal3-io/metal3-dev-env#879 which need resolving, then we can merge that and update the dev-scripts pin

hardys · 2022-01-12T10:53:47Z

    netmask_v4: "{{ baremetal_network_cidr_v4|ipaddr('netmask') }}"
    address_v6: "{{ baremetal_network_cidr_v6|nthhost(1)|default('', true) }}"
    prefix_v6: "{{ baremetal_network_cidr_v6|ipaddr('prefix') }}"
+    dhcp_enabled: "{{ virsh_dhcp_enabled|bool }}"


Another option is we conditionally define dhcp_range* - then we won't need the new metal3-dev-env flag since the <dhcp stanza is already skipped when the range is omitted

I pushed metal3-io/metal3-dev-env#902 which means we can just set the dhcp_range variables to an empty list, which avoids the need for a new variable

hardys · 2022-01-13T11:01:10Z

I pushed #1336 which handles the bootstrap VM ip configuration, which we'll need for this

Set up a STATIC_IPS configuration flag that configures dev-scripts to use static IPs (v4 and/or v6) for the baremetal network. Co-Authored-By: Caleb Boylan <cboylan@redhat.com>

openshift-ci · 2022-05-10T09:28:21Z

@imain: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-09-08T17:10:56Z

@imain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack	`e5d94f1`	link	false	`/test e2e-metal-ipi-ovn-dualstack`
ci/prow/e2e-metal-ipi-virtualmedia	`e5d94f1`	link	false	`/test e2e-metal-ipi-virtualmedia`
ci/prow/e2e-metal-ipi-serial-ovn-ipv6	`e5d94f1`	link	true	`/test e2e-metal-ipi-serial-ovn-ipv6`
ci/prow/e2e-metal-ipi-proxy-ipv4	`e5d94f1`	link	true	`/test e2e-metal-ipi-proxy-ipv4`
ci/prow/e2e-metal-ipi-proxy-ipv6	`e5d94f1`	link	true	`/test e2e-metal-ipi-proxy-ipv6`
ci/prow/e2e-agent-compact	`e5d94f1`	link	true	`/test e2e-agent-compact`
ci/prow/e2e-metal-ipi	`e5d94f1`	link	true	`/test e2e-metal-ipi`
ci/prow/e2e-metal-ipi-serial-ipv4	`e5d94f1`	link	true	`/test e2e-metal-ipi-serial-ipv4`
ci/prow/e2e-metal-ipi-ovn-ipv6	`e5d94f1`	link	true	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-metal-ipi-bm	`e5d94f1`	link	true	`/test e2e-metal-ipi-bm`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

derekhiggins · 2022-09-09T16:33:01Z

Closing as this has been handled by #1418

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2021

openshift-ci Bot requested review from cybertron and sadasu October 4, 2021 21:28

imain mentioned this pull request Oct 4, 2021

WIP: Set static IP variables for ironic nodes metal3-io/metal3-dev-env#820

Closed

hardys reviewed Oct 11, 2021

View reviewed changes

Comment thread 02_configure_host.sh Outdated

hardys reviewed Oct 11, 2021

View reviewed changes

Comment thread utils.sh Outdated

hardys reviewed Oct 11, 2021

View reviewed changes

Comment thread utils.sh Outdated

imain force-pushed the static_ips branch from 62d84f5 to 69229d0 Compare November 15, 2021 22:45

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021

imain force-pushed the static_ips branch from 69229d0 to 18a0544 Compare November 18, 2021 20:26

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2021

imain force-pushed the static_ips branch from 18a0544 to 80710fd Compare November 18, 2021 21:08

imain force-pushed the static_ips branch from 80710fd to 3214ed8 Compare December 6, 2021 17:01

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2021

imain force-pushed the static_ips branch from 3214ed8 to 7ff8505 Compare December 6, 2021 17:03

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2021

imain force-pushed the static_ips branch from 7ff8505 to ea79c8e Compare December 13, 2021 22:34

imain changed the title ~~WIP: Add ability to inject static ips into install-config~~ Add ability to inject static ips into install-config Dec 13, 2021

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2021

hardys reviewed Dec 20, 2021

View reviewed changes

derekhiggins reviewed Dec 21, 2021

View reviewed changes

hardys reviewed Jan 12, 2022

View reviewed changes

hardys mentioned this pull request Jan 12, 2022

Add ENABLE_BOOTSTRAP_STATIC_IP option #1336

Merged

derekhiggins mentioned this pull request Jan 26, 2022

WIP: Static ip #1342

Closed

Add ability to inject static ips into install-config

e5d94f1

Set up a STATIC_IPS configuration flag that configures dev-scripts to use static IPs (v4 and/or v6) for the baremetal network. Co-Authored-By: Caleb Boylan <cboylan@redhat.com>

imain force-pushed the static_ips branch from ea79c8e to e5d94f1 Compare March 2, 2022 19:12

derekhiggins mentioned this pull request May 10, 2022

baremetal: Add bootstrap-external-ip openshift/enhancements#1071

Merged

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2022

derekhiggins closed this Sep 9, 2022

Conversation

imain commented Oct 4, 2021

Uh oh!

openshift-ci Bot commented Oct 4, 2021

Uh oh!

imain commented Oct 4, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bfournie commented Dec 16, 2021

Uh oh!

hardys Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

hardys Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

hardys Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

derekhiggins Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

hardys commented Jan 5, 2022

Uh oh!

hardys commented Jan 5, 2022

Uh oh!

hardys Jan 12, 2022

Choose a reason for hiding this comment

Uh oh!

hardys Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

hardys commented Jan 13, 2022

Uh oh!

openshift-ci Bot commented May 10, 2022

Uh oh!

openshift-ci Bot commented Sep 8, 2022

Uh oh!

derekhiggins commented Sep 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants