[WIP] Generate clouds.yaml for ironic and ironic-inspector and document it#612
Closed
dtantsur wants to merge 1 commit intoopenshift-metal3:masterfrom
Closed
[WIP] Generate clouds.yaml for ironic and ironic-inspector and document it#612dtantsur wants to merge 1 commit intoopenshift-metal3:masterfrom
dtantsur wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
…ng it The main benefit is that we'll be able to use ironic and ironic-inspector simultaneously, without redefining OS_URL each time.
dhellmann
requested changes
Jun 26, 2019
| --pod ironic-pod -v $IRONIC_DATA_DIR:/shared "${IRONIC_INSPECTOR_IMAGE}" | ||
|
|
||
| sudo mkdir -p /etc/openstack | ||
| sudo cat > /etc/openstack/clouds.yaml <<EOF |
Member
There was a problem hiding this comment.
This is going to replace any existing file or settings that might already be present. I think we should generate the file to ./ocs like we do with the kube auth file and suggest that the user copy it (or its contents) to their home directory.
Member
|
This seems worthwhile, any plans to revisit it? Perhaps updating it after #642 is merged? |
Member
Author
|
Yep, I'm waiting for the location of ironic to settle down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main benefit is that we'll be able to use ironic and ironic-inspector
simultaneously, without redefining OS_URL each time.
To actually work we need the following patches merged and released:
osc-lib: https://review.opendev.org/#/c/664830/
ironic-inspector-client: https://review.opendev.org/#/c/664835/