WIP: assets: Drop ingress-controller manifest.#699
Closed
russellb wants to merge 1 commit intoopenshift-metal3:masterfrom
Closed
WIP: assets: Drop ingress-controller manifest.#699russellb wants to merge 1 commit intoopenshift-metal3:masterfrom
russellb wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
The intention of this manifest was to change the node selector so that the ingress controller would run on masters. This manifest is owned by the ingress operator, so our changes would just get overwritten. In my local cluster, that does appear to be the case and there's no node selector setting at all.
Member
Author
|
Marked as WIP while CI runs ... |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/951/ |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/954/ |
Member
Author
|
The CI failure is real here. This change is still needed, so more work is needed to figure out the right change to make to be able to drop this manifest. |
Member
Author
|
tracked via #705 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention of this manifest was to change the node selector so that
the ingress controller would run on masters.