Fix and clean up release image variables#740
Merged
russellb merged 2 commits intoopenshift-metal3:masterfrom Aug 16, 2019
Merged
Fix and clean up release image variables#740russellb merged 2 commits intoopenshift-metal3:masterfrom
russellb merged 2 commits intoopenshift-metal3:masterfrom
Conversation
Member
stbenjam
commented
Aug 16, 2019
stbenjam
commented
- Rename OPENSHIFT_RELEASE_IMAGE_OVERRIDE to the correct OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE
- Remove reference to RELEASE_IMAGE (removed in hack: remove compile time RELEASE_IMAGE override openshift/installer#2217)
This no longer works in the installer, setting OPENSHIFT_RELEASE_IMAGE_OVERRIDE at runtime is the way to override the release.
…IMAGE_OVERRIDE The correct variable used by the installer is OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.