Skip to content

Add support to test against alternative branches#823

Merged
stbenjam merged 1 commit intoopenshift-metal3:masterfrom
derekhiggins:base_branch
Oct 10, 2019
Merged

Add support to test against alternative branches#823
stbenjam merged 1 commit intoopenshift-metal3:masterfrom
derekhiggins:base_branch

Conversation

@derekhiggins
Copy link
Copy Markdown
Collaborator

Use BASE_BRANCH to represent the branch a PR is
opened against. We've change the scripts that
trigger run_ci.sh to pass this down the line.

Fixes: #822

@derekhiggins derekhiggins added the CI check this PR with CI label Oct 8, 2019
Copy link
Copy Markdown
Member

@stbenjam stbenjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to run a test, I have stbenjam/installer:ci-branch you could use against release-4.2 in the installer

@metal3ci
Copy link
Copy Markdown

metal3ci commented Oct 8, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1201/

@metal3ci
Copy link
Copy Markdown

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1206/

@metal3ci
Copy link
Copy Markdown

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1207/

Use BASE_BRANCH to represent the branch a PR is
opened against. We've change the scripts that
trigger run_ci.sh to pass this down the line.

Fixes: openshift-metal3#822
@derekhiggins
Copy link
Copy Markdown
Collaborator Author

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1207/

This tested the patch with a test on the release-4.2 branch of installer
eec3163

@metal3ci
Copy link
Copy Markdown

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1208/

@stbenjam stbenjam merged commit 2a31d50 into openshift-metal3:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI check this PR with CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metal3 CI can't test against other installer branches

3 participants