Changes to enable testing with an IPv6 controlplane#902
Merged
russellb merged 6 commits intoopenshift-metal3:masterfrom Jan 24, 2020
Merged
Changes to enable testing with an IPv6 controlplane#902russellb merged 6 commits intoopenshift-metal3:masterfrom
russellb merged 6 commits intoopenshift-metal3:masterfrom
Conversation
added 5 commits
January 24, 2020 16:19
So we can access it via ipv6
Instead of a regex which only accepts ipv4 addresses
Since the oc adm mirror command appears to reject target registries and pullspecs that contain ipv6 addresses[1] we can work around this by using a name instead [1] openshift/oc#239
This is required to access the local registry by name (and for the related SSL certs)
Default to the values from the installer for ipv4, but we can override like this for ipv6: export CLUSTER_SUBNET="fd01::/48" export CLUSTER_HOST_PREFIX="64" export SERVICE_SUBNET="fd02::/112" Co-Authored-By: Russell Bryant <rbryant@redhat.com>
hardys
changed the title
stbenjam
reviewed
Jan 24, 2020
| # IPv6 network config validation | ||
| if [[ "${EXTERNAL_SUBNET}" =~ .*:.* ]]; then | ||
| if [[ "${NETWORK_TYPE}" != "OVNKubernetes" ]]; then | ||
| echo "NETWORK_TYPE must be OVNKubernetes when using IPv6" |
Member
There was a problem hiding this comment.
Could we just set this to OVNKubernetes if we detect IPv6?
Author
There was a problem hiding this comment.
I guess we could - @russellb do you think anyone is likely to test anything other than OVNKubernetes here?
Member
There was a problem hiding this comment.
They shouldn't. I'm OK with just setting it instead of telling them to set it ...
Member
|
Otherwise LGTM |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1456/ |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes to allow testing with ipv6 enabled controlplane, the related config looks like:
Note this also requires a special release image and some image customizations atm while related OCP/RHCOS fixes land