Skip to content

BUILD-353: switch to final agreed upon name for shared resource csi driver name#1019

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
gabemontero:shared-resource-driver-name-fix
Oct 7, 2021
Merged

BUILD-353: switch to final agreed upon name for shared resource csi driver name#1019
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
gabemontero:shared-resource-driver-name-fix

Conversation

@gabemontero
Copy link
Copy Markdown
Contributor

@gabemontero gabemontero commented Oct 5, 2021

@gabemontero gabemontero changed the title switch to final agreed upon name for shared resource csi driver name BUILD-353: switch to final agreed upon name for shared resource csi driver name Oct 5, 2021
@openshift-ci openshift-ci Bot requested review from bparees and sttts October 5, 2021 16:59
@gabemontero
Copy link
Copy Markdown
Contributor Author

gabemontero commented Oct 5, 2021

/assign @deads2k
/assign @jsafrane
/assign @adambkaplan

@gabemontero gabemontero mentioned this pull request Oct 5, 2021
Merged
@coreydaley
Copy link
Copy Markdown

coreydaley commented Oct 5, 2021

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2021
@gabemontero
Copy link
Copy Markdown
Contributor Author

gabemontero commented Oct 5, 2021

@coreydaley has asked that I make a minor fix to his recent update, specifically at https://github.com/openshift/api/blob/master/sharedresource/v1alpha1/types_shared_configmap.go#L63

I'll do that as a separate commit, and release the hold once I have it up

@gabemontero
Copy link
Copy Markdown
Contributor Author

gabemontero commented Oct 5, 2021

/hold cancel

/assign @coreydaley

please confirm I covered everything you were expecting - thanks

@gabemontero
Copy link
Copy Markdown
Contributor Author

gabemontero commented Oct 5, 2021

maybe in this repo I don't have permission to cancel your hold @coreydaley

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2021
@coreydaley
Copy link
Copy Markdown

coreydaley commented Oct 5, 2021

/hold cancel
looks good to me

@coreydaley coreydaley mentioned this pull request Oct 5, 2021
Merged
@coreydaley
Copy link
Copy Markdown

coreydaley commented Oct 6, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2021
adambkaplan
adambkaplan approved these changes Oct 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Oct 6, 2021

/assign @deads2k

Two items we missed in the initial merged API.

@gabemontero gabemontero mentioned this pull request Oct 6, 2021
Merged
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Oct 7, 2021

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley, deads2k, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4cb30f2 into openshift:master Oct 7, 2021
@gabemontero gabemontero deleted the shared-resource-driver-name-fix branch October 7, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@sttts sttts Awaiting requested review from sttts

1 more reviewer

@adambkaplan adambkaplan adambkaplan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adambkaplan adambkaplan

@jsafrane jsafrane

@coreydaley coreydaley

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabemontero @coreydaley @adambkaplan @deads2k @jsafrane @openshift-merge-robot