Skip to content

Add AlibabaPlatform feature gate to TechPreviewNoUpgrade#1478

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JoelSpeed:alibaba-feature-gate
Jun 2, 2023
Merged

Add AlibabaPlatform feature gate to TechPreviewNoUpgrade#1478
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JoelSpeed:alibaba-feature-gate

Conversation

@JoelSpeed
Copy link
Copy Markdown
Contributor

Alibaba as a platform should always have been behind a feature gate. To start the process of unwinding it, we should put everything behind a feature gate that is related to Alibaba.

Adding it to Default for now, we must move it to TPNU before 4.14 ships. Will need to make sure that every cluster installed as Alibaba going forward includes the TechPreviewNoUpgrade FeatureSet.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2023

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2023
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jun 2, 2023

/lgtm

@openshift-ci openshift-ci Bot requested review from deads2k and soltysh June 2, 2023 14:27
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2023

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3d62a6b into openshift:master Jun 2, 2023
sinnykumari added a commit to sinnykumari/machine-config-operator that referenced this pull request Jun 7, 2023
@JoelSpeed JoelSpeed deleted the alibaba-feature-gate branch January 28, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants