Skip to content

Add MachineAPIOperatorDisableMachineHealthCheckController feature gate#1523

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
slintes:mao_disable_mhc_fg
Jul 11, 2023
Merged

Add MachineAPIOperatorDisableMachineHealthCheckController feature gate#1523
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
slintes:mao_disable_mhc_fg

Conversation

@slintes
Copy link
Copy Markdown
Member

@slintes slintes commented Jul 11, 2023 •
edited
Loading

This feature gate is for disabling the MachineHealthCheck controller of Machine API operator, in order to let the NodeHealthcheck operator handle MachineHealthChecks.
This is an incomplete feature atm, so it's not enabled in the TechPreviewNoUpgrade feature set yet.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 11, 2023

Hello @slintes! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 11, 2023
@slintes
Copy link
Copy Markdown
Member Author

slintes commented Jul 11, 2023

/cc @JoelSpeed

@openshift-ci openshift-ci Bot requested review from JoelSpeed, sjenning and soltysh July 11, 2023 09:01
JoelSpeed
JoelSpeed reviewed Jul 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Jul 11, 2023

/lgtm cancel

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 11, 2023
@slintes
Add MachineAPIOperatorDisableMachineHealthCheckController feature gate
46fa26b 
This feature gate is for disabling the MachineHealthCheck controller of
Machine API operator, in order to let the NodeHealthcheck operator handle
MachineHealthChecks.
This is an incomplete feature atm, so it's not enabled in the
TechPreviewNoUpgrade feature set yet.
@slintes slintes force-pushed the mao_disable_mhc_fg branch from 4b1e72e to 46fa26b Compare July 11, 2023 09:29
JoelSpeed
JoelSpeed reviewed Jul 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 11, 2023

@slintes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ca06f4a into openshift:master Jul 11, 2023
This was referenced Jul 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@sjenning sjenning Awaiting requested review from sjenning

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slintes @JoelSpeed @openshift-merge-robot