OCPVE-658: add CloudController capability#1579
Conversation
|
@qJkee: This pull request references OCPVE-658 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fae7eb2 to
d90a3dc
Compare
|
This PR has a number of PRs depending on it. However, as far as I can tell there's some major new code being introduced to support this (especially in MCO) which is yet to be reviewed. I would like to see the code owners for the dependent PRs to have reviewed and agreed to merge the code before we merge this API. Given the timelines for branching, I'm concerned that merging this without the other PRs being ready will result in a half merged feature come branch day. |
|
@qJkee: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
elmiko
left a comment
There was a problem hiding this comment.
i'm not an expert on the capability stuff, but this generally looks correct to me.
|
Based on testing feedback in https://issues.redhat.com/browse/OCPEDGE-269 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, qJkee The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.16.0-202403011138.p0.gce10821.assembly.stream.el9 for distgit ose-cluster-config-api. |
No description provided.