Skip to content

OCPVE-658: add CloudController capability#1579

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
qJkee:OCPVE-658
Mar 1, 2024
Merged

OCPVE-658: add CloudController capability#1579
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
qJkee:OCPVE-658

Conversation

@qJkee
Copy link
Copy Markdown
Contributor

@qJkee qJkee commented Sep 5, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 5, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 5, 2023

@qJkee: This pull request references OCPVE-658 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 5, 2023
@openshift-ci openshift-ci Bot requested review from bparees and soltysh September 5, 2023 18:41
@qJkee qJkee force-pushed the OCPVE-658 branch 2 times, most recently from fae7eb2 to d90a3dc Compare October 24, 2023 16:07
@JoelSpeed
Copy link
Copy Markdown
Contributor

This PR has a number of PRs depending on it. However, as far as I can tell there's some major new code being introduced to support this (especially in MCO) which is yet to be reviewed.

I would like to see the code owners for the dependent PRs to have reviewed and agreed to merge the code before we merge this API. Given the timelines for branching, I'm concerned that merging this without the other PRs being ready will result in a half merged feature come branch day.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 25, 2024

@qJkee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 9bd6824 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not an expert on the capability stuff, but this generally looks correct to me.

@JoelSpeed
Copy link
Copy Markdown
Contributor

Based on testing feedback in https://issues.redhat.com/browse/OCPEDGE-269

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit ce10821 into openshift:master Mar 1, 2024
@openshift-bot
Copy link
Copy Markdown

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202403011138.p0.gce10821.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants