Skip to content

OCPBUGS-22364: Make MCO certificate observability fields optional for 4.15 #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Nov 21, 2023
Merged

OCPBUGS-22364: Make MCO certificate observability fields optional for 4.15 #1637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23af240
MCO: make certificate dates optional
jkyros Oct 25, 2023
23b9402
make update
jkyros Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions machineconfiguration/v1/0000_80_controllerconfig.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,8 +1224,6 @@ spec:
type: object
required:
- bundleFile
- notAfter
- notBefore
- signer
- subject
properties:
Expand Down
1 change: 0 additions & 1 deletion machineconfiguration/v1/0000_80_machineconfigpool.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ spec:
type: object
required:
- bundle
- expiry
- subject
properties:
bundle:
Expand Down
6 changes: 3 additions & 3 deletions machineconfiguration/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,11 @@ type ControllerCertificate struct {
Signer string `json:"signer"`

// notBefore is the lower boundary for validity
// +kubebuilder:validation:Required
// +optional
NotBefore *metav1.Time `json:"notBefore"`

// notAfter is the upper boundary for validity
// +kubebuilder:validation:Required
// +optional
NotAfter *metav1.Time `json:"notAfter"`

// bundleFile is the larger bundle a cert comes from
Expand Down Expand Up @@ -445,7 +445,7 @@ type CertExpiry struct {
// +kubebuilder:validation:Required
Subject string `json:"subject"`
// expiry is the date after which the certificate will no longer be valid
// +kubebuilder:validation:Required
// +optional
Expiry *metav1.Time `json:"expiry"`
}

Expand Down