Skip to content

OCPBUGS-15934: use *resource.Quantity to not automatically set 0 #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Nov 15, 2023
Merged

OCPBUGS-15934: use *resource.Quantity to not automatically set 0 #1656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions machineconfiguration/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,12 +679,12 @@ type ContainerRuntimeConfiguration struct {
// Negative numbers indicate that no size limit is imposed.
// If it is positive, it must be >= 8192 to match/exceed conmon's read buffer.
// +optional
LogSizeMax resource.Quantity `json:"logSizeMax,omitempty"`
LogSizeMax *resource.Quantity `json:"logSizeMax,omitempty"`

// overlaySize specifies the maximum size of a container image.
// This flag can be used to set quota on the size of container images. (default: 10GB)
// +optional
OverlaySize resource.Quantity `json:"overlaySize,omitempty"`
OverlaySize *resource.Quantity `json:"overlaySize,omitempty"`

// defaultRuntime is the name of the OCI runtime to be used as the default.
// +optional
Expand Down
12 changes: 10 additions & 2 deletions machineconfiguration/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.