Skip to content

Run update-payload-crds after update-codegen-crds#1974

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Prashanth684:api-mk
Aug 2, 2024
Merged

Run update-payload-crds after update-codegen-crds#1974
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Prashanth684:api-mk

Conversation

@Prashanth684
Copy link
Copy Markdown
Contributor

@Prashanth684 Prashanth684 commented Jul 26, 2024

When working on #1928, noticed that the payload crds were not generated after running a make update. This is because codegen is run after update-scripts. This PR removes update-payload-crds from update-scripts and runs it after codegen.

@Prashanth684
Run update-payload-crds after update-codegen-crds
d90bbea 
When working on openshift#1928, noticed that the paylaod crds were not being
generated after running a `make update`. This is because codegen is run
after update-scripts. This PR removes update-payload-crds from
update-scripts and runs it after codegen.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 26, 2024

Hello @Prashanth684! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2024
@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Jul 26, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@Prashanth684
Copy link
Copy Markdown
Contributor Author

Prashanth684 commented Jul 26, 2024

/retest-required

1 similar comment
@Prashanth684
Copy link
Copy Markdown
Contributor Author

Prashanth684 commented Jul 31, 2024

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 31, 2024

/retest-required

Remaining retests: 0 against base HEAD 0d46442 and 2 for PR HEAD d90bbea in total

@Prashanth684
Copy link
Copy Markdown
Contributor Author

Prashanth684 commented Jul 31, 2024

/test e2e-aws-serial-techpreview

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 31, 2024

/retest-required

Remaining retests: 0 against base HEAD e863d9f and 1 for PR HEAD d90bbea in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 1, 2024

/retest-required

Remaining retests: 0 against base HEAD c299a67 and 0 for PR HEAD d90bbea in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 1, 2024

/hold

Revision d90bbea was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 1, 2024 •
edited
Loading

@Prashanth684: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp d90bbea link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Aug 2, 2024

/hold cancel
/override ci/prow/e2e-aws-ovn

This PR doesn't affect the E2Es

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 2, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn

Details

In response to this:

/hold cancel
/override ci/prow/e2e-aws-ovn

This PR doesn't affect the E2Es

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 2, 2024

/retest-required

Remaining retests: 0 against base HEAD 8b2b377 and 2 for PR HEAD d90bbea in total

@openshift-merge-bot openshift-merge-bot Bot merged commit 7461358 into openshift:master Aug 2, 2024
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Aug 3, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408030144.p0.g7461358.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Prashanth684 @JoelSpeed @openshift-ci-robot @openshift-bot