MULTIARCH-4559: config/v1/types_cluster_version.go: Add 'architecture' to the release structure by wking · Pull Request #2024 · openshift/api

wking · 2024-09-10T22:14:53Z

As requested in the enhancement. Motivation for the new property from the enhancement:

There were a few options discussed in lieu of introducing a new ClusterVersion status field and the potential risks for doing so. The alternatives are highlighted with reasoning given for why they were not pursued:

Default ImportMode to PreserveOriginal everywhere: single-arch-release users maybe concerned about import size and the lack of metadata like dockerImageLayers and dockerImageMetadata for manifestlisted imagestream tags.

Clusters with homogeneous nodes running the multi payload who do not want to import manifestlists: The clusters can either migrate to single arch payloads or manually toggle the importMode through the image config CRD.

CVO provides architecural knowledge to the cluster-image-registry-operator through a configmap or the image config CRD: To limit the risk of many external consumers using CVO's status field to determine that their cluster is multi-arch ready, the idea was to expose this information to the specific controller. This solution is not necessary as we let other controller implementers decide if the CVO's new status field is the best fit for their use case.

openshift-ci-robot · 2024-09-10T22:14:57Z

@wking: This pull request references MULTIARCH-4559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

As requested in the enhancement. Motivation for the new property from the enhancement:

There were a few options discussed in lieu of introducing a new ClusterVersion status field and the potential risks for doing so. The alternatives are highlighted with reasoning given for why they were not pursued:

Default ImportMode to PreserveOriginal everywhere: single-arch-release users maybe concerned about import size and the lack of metadata like dockerImageLayers and dockerImageMetadata for manifestlisted imagestream tags.

Clusters with homogeneous nodes running the multi payload who do not want to import manifestlists: The clusters can either migrate to single arch payloads or manually toggle the importMode through the image config CRD.

CVO provides architecural knowledge to the cluster-image-registry-operator through a configmap or the image config CRD: To limit the risk of many external consumers using CVO's status field to determine that their cluster is multi-arch ready, the idea was to expose this information to the specific controller. This solution is not necessary as we let other controller implementers decide if the CVO's new status field is the best fit for their use case.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-09-10T22:15:04Z

Hello @wking! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

deads2k · 2024-09-16T13:46:00Z

+	// Valid values are 'Multi' and empty.
+	//
+	// +optional
+	Architecture ClusterVersionArchitecture `json:"architecture,omitempty"`


Needs featuregate.

Which feature gate would you like? The enhancement is pretty thin in that section.

the ImageStreamImportMode featuregate implemented here: #1928

Feature gate added as of 7f3382e. The verify-crd-schema failures are all existing properties in the new-with-this-pull clusterversions.config.openshift.io/ImageStreamImportMode.yaml file, and they'll need the /override ci/prow/verify-crd-schema mentioned in the failure message.

deads2k · 2024-09-16T13:46:33Z

+	// value of the cluster architecture. In this context cluster
+	// architecture means either a single architecture or a multi
+	// architecture.
+	// Valid values are 'Multi' and empty.


This may very well end up extended with more detail in the near future, but starting here is acceptable.

Prashanth684 · 2024-11-08T19:46:21Z

@wking any progress on this?

…ructure As requested in the enhancement [1]. Motivation for the new property from the enhancement [2]: There were a few options discussed in lieu of introducing a new ClusterVersion status field and the potential risks for doing so. The alternatives are highlighted with reasoning given for why they were not pursued: * Default ImportMode to PreserveOriginal everywhere: single-arch-release users maybe concerned about import size and the lack of metadata like dockerImageLayers and dockerImageMetadata for manifestlisted imagestream tags. * Clusters with homogeneous nodes running the multi payload who do not want to import manifestlists: The clusters can either migrate to single arch payloads or manually toggle the importMode through the image config CRD. * CVO provides architecural knowledge to the cluster-image-registry-operator through a configmap or the image config CRD: To limit the risk of many external consumers using CVO's status field to determine that their cluster is multi-arch ready, the idea was to expose this information to the specific controller. This solution is not necessary as we let other controller implementers decide if the CVO's new status field is the best fit for their use case. David and Prashanth requested the ImageStreamImportMode feature gating in [3]. [1]: https://github.com/openshift/enhancements/blob/36ef3f51e5b7bfb2d4af18d415ba762e0a0431ac/enhancements/multi-arch/dynamic-imagestream-importmode-setting.md#api-extensions [2]: https://github.com/openshift/enhancements/blob/36ef3f51e5b7bfb2d4af18d415ba762e0a0431ac/enhancements/multi-arch/dynamic-imagestream-importmode-setting.md#motivations-for-a-new-clusterversion-status-property [3]: openshift#2024 (comment)

Generated using: $ PROTO_OPTIONAL=true make update

…ructure As requested in the enhancement [1]. Motivation for the new property from the enhancement [2]: There were a few options discussed in lieu of introducing a new ClusterVersion status field and the potential risks for doing so. The alternatives are highlighted with reasoning given for why they were not pursued: * Default ImportMode to PreserveOriginal everywhere: single-arch-release users maybe concerned about import size and the lack of metadata like dockerImageLayers and dockerImageMetadata for manifestlisted imagestream tags. * Clusters with homogeneous nodes running the multi payload who do not want to import manifestlists: The clusters can either migrate to single arch payloads or manually toggle the importMode through the image config CRD. * CVO provides architecural knowledge to the cluster-image-registry-operator through a configmap or the image config CRD: To limit the risk of many external consumers using CVO's status field to determine that their cluster is multi-arch ready, the idea was to expose this information to the specific controller. This solution is not necessary as we let other controller implementers decide if the CVO's new status field is the best fit for their use case. David an Prashanth requested the ImageStreamImportMode feature gating in [3]. [1]: https://github.com/openshift/enhancements/blob/36ef3f51e5b7bfb2d4af18d415ba762e0a0431ac/enhancements/multi-arch/dynamic-imagestream-importmode-setting.md#api-extensions [2]: https://github.com/openshift/enhancements/blob/36ef3f51e5b7bfb2d4af18d415ba762e0a0431ac/enhancements/multi-arch/dynamic-imagestream-importmode-setting.md#motivations-for-a-new-clusterversion-status-property [3]: openshift#2024 (comment)

…Mode: New tests For the new feature-set flavor. I copied AAA_ungated.yaml, added the featureGate property, and then updated every existing Release structure to set 'architecture: Multi'.

Prashanth684 · 2024-11-15T22:37:35Z

/lgtm

deads2k · 2024-11-18T22:47:44Z

/override ci/prow/verify-crd-schema
/approve

openshift-ci · 2024-11-18T22:47:49Z

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema

Details

In response to this:

/override ci/prow/verify-crd-schema
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2024-11-18T22:47:52Z

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci · 2024-11-18T22:48:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Prashanth684, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2024-11-19T03:45:45Z

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202411190035.p0.g25d2eec.assembly.stream.el9.
All builds following this will include this PR.

Pulling in [1]. Generated with: $ go get github.com/openshift/api@master $ go mod tidy $ go mod vendor $ git add -A go.* vendor using: $ go version go version go1.23.1 linux/amd64 [1]: openshift/api#2024

…on desired Architecture openshift/api#2024 introduces the architecture property in the desired status field which indicates the architecture of the cluster (or the architecture being reconciled to). Set import mode based on this status - if "Multi", set importmode to PreserveOriginal, else to Legacy.

…on desired Architecture openshift/api#2024 introduces the architecture property in the desired status field which indicates the architecture of the cluster (or the architecture being reconciled to). Set import mode based on this status - if "Multi", set importmode to PreserveOriginal, else to Legacy. Backport of openshift#1164

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2024

openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2024

openshift-ci Bot requested review from bparees and derekwaynecarr September 10, 2024 22:15

Prashanth684 reviewed Sep 10, 2024

View reviewed changes

Comment thread config/v1/types_cluster_version.go

openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2024

deads2k reviewed Sep 16, 2024

View reviewed changes

wking force-pushed the release-architecture-property branch from f153ad8 to 49ec891 Compare November 15, 2024 00:18

config/v1: Update generated assets for Release.architecture

31505ab

Generated using: $ PROTO_OPTIONAL=true make update

wking force-pushed the release-architecture-property branch from 49ec891 to 31505ab Compare November 15, 2024 03:20

openshift-ci Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2024

wking force-pushed the release-architecture-property branch from 31505ab to 86a5195 Compare November 15, 2024 03:48

config/v1/tests/clusterversions.config.openshift.io/ImageStreamImport…

7f3382e

…Mode: New tests For the new feature-set flavor. I copied AAA_ungated.yaml, added the featureGate property, and then updated every existing Release structure to set 'architecture: Multi'.

wking force-pushed the release-architecture-property branch from fe67da3 to 7f3382e Compare November 15, 2024 15:27

openshift-ci Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 15, 2024

openshift-ci Bot assigned Prashanth684 Nov 15, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024

openshift-merge-bot Bot merged commit 25d2eec into openshift:master Nov 18, 2024

wking deleted the release-architecture-property branch November 19, 2024 01:49

wking mentioned this pull request Nov 19, 2024

MULTIARCH-4559: pkg: Propagate Release.Architecture openshift/cluster-version-operator#1110

Merged

Prashanth684 mentioned this pull request Nov 26, 2024

MULTIARCH-4971: Set import mode in image config based on ClusterVersion desired Architecture openshift/cluster-image-registry-operator#1164

Merged

Prashanth684 mentioned this pull request Dec 17, 2024

[release-4.18]: MULTIARCH-4971: Set import mode in image config based on ClusterVersion desired Architecture openshift/cluster-image-registry-operator#1167

Merged

Conversation

wking commented Sep 10, 2024

Uh oh!

openshift-ci-robot commented Sep 10, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Sep 10, 2024

Uh oh!

Uh oh!

deads2k Sep 16, 2024

Choose a reason for hiding this comment

Uh oh!

wking Sep 16, 2024

Choose a reason for hiding this comment

Uh oh!

Prashanth684 Sep 16, 2024

Choose a reason for hiding this comment

Uh oh!

wking Nov 15, 2024

Choose a reason for hiding this comment

Uh oh!

deads2k Sep 16, 2024

Choose a reason for hiding this comment

Uh oh!

Prashanth684 commented Nov 8, 2024

Uh oh!

Prashanth684 commented Nov 15, 2024

Uh oh!

deads2k commented Nov 18, 2024

Uh oh!

openshift-ci Bot commented Nov 18, 2024

Uh oh!

openshift-ci Bot commented Nov 18, 2024

Uh oh!

openshift-ci Bot commented Nov 18, 2024

Uh oh!

openshift-bot commented Nov 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci-robot commented Sep 10, 2024 •

edited by openshift-ci Bot

Loading