[release-4.19] MCO-1720: Promote MachineConfigNode feature gate to default#2376
Conversation
|
@isabella-janssen: This pull request references MCO-1720 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Hello @isabella-janssen! Some important instructions when contributing to openshift/api: |
openshift-ci
Bot
added
the
size/XXL
|
/retest-required |
|
@isabella-janssen We don't generally backport feature promotions post GA unless there is a very very good reason to do so, what's the motivation here? |
|
@JoelSpeed Hi! Due to it finalizing in the last minute, the aggreement was to push it via 4.19 z-stream.
Overall, the api does exist for a while, and is a mature one. I hope the above clarifies things, but when we saw that we missed 4.19 the agreed plan was to backport. |
|
/retest-required |
|
Do we have the associated SBAR for this feature backport that we can link here? |
|
/hold Holding while we create an SBAR for this feature & PinnedImage sets. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/retest-required |
3 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/test verify-feature-promotion |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/test verify-feature-promotion |
|
/retest-required |
|
As far as I can tell, some tests have been renamed recetly and those haven't timed out yet. The only test I can see which doesn't pass enough is If we can get a few more runs there to see if it comes above 95% I think we are good to promote this |
|
/retest-required |
That's correct, they were updated June 26th (openshift/origin#29918).
I have some manually triggered runs for that running now, hopefully we can get the passing rate up soon. Related SBAR can be found here. Thanks for the continued patience and help throughout this effort @JoelSpeed! |
|
/test verify-feature-promotion |
2 similar comments
|
/test verify-feature-promotion |
|
/test verify-feature-promotion |
|
@JoelSpeed This should be ready for reconsideration. |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
Should be safe to go now that openshift/machine-config-operator#5243 is in 4.19
|
/hold Holding until SBAR is reviewed & approved by Nick Stielau and Kirsten Newcomer. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/test verify-feature-promotion |
|
/lgtm /override ci/prow/verify-feature-promotion Having reviewed sippy, I'm fairly happy that the lanes that have below 95% are from failures over a week ago. Most appeared to be networking/API server comms issues which should be unrelated to this feature |
openshift-ci
Bot
added
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, JoelSpeed, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/verified by ci/prow/verify-feature-promotion |
openshift-ci-robot
added
the
verified
|
@JoelSpeed: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel SBAR is approved |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/skip |
|
/test okd-scos-images |
1 similar comment
|
/override ci/prow/verify-feature-promotion |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@isabella-janssen: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit ce7baf0
into
openshift:release-4.19
8 participants
This promotes the
MachineConfigNodefeature gate toDefaultin the 4.19 brach.