CORS-4221: Remove the OAUTH and STS endpoints

[barbacbd]

** The GCP endpoints for oauth and sts should not be overridden using the Private Service Connect. While these appear to be services just like the others (ex compute) they are not to be overridden as per google. Remove the option to override these endpoints.

[openshift-ci-robot]

@barbacbd: This pull request references CORS-4221 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

** The GCP endpoints for oauth and sts should not be overridden using the Private Service Connect. While these appear to be services just like the others (ex compute) they are not to be overridden as per google. Remove the option to override these endpoints.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @barbacbd! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[JoelSpeed]

This API is only available in tech preview. While normally removing an enum value is a breaking change, for tech preview we are able to make this change since we don't support upgrades

/lgtm
/verified bypass

This won't need verification

/override ci/prow/verify-crd-schema

[openshift-ci-robot]

@JoelSpeed: The verified label has been added.

Details

In response to this:

This API is only available in tech preview. While normally removing an enum value is a breaking change, for tech preview we are able to make this change since we don't support upgrades

/lgtm
/verified bypass

This won't need verification

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/test remaining-required

Scheduling tests matching the pipeline_run_if_changed parameter:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

Details

In response to this:

This API is only available in tech preview. While normally removing an enum value is a breaking change, for tech preview we are able to make this change since we don't support upgrades

/lgtm
/verified bypass

This won't need verification

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 04f99ea and 2 for PR HEAD ccf8770 in total

[JoelSpeed]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8a46f74 and 1 for PR HEAD ccf8770 in total

[barbacbd]

/retest-required

[JoelSpeed]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a5edeb5 and 0 for PR HEAD ccf8770 in total

[openshift-ci-robot]

/hold

Revision ccf8770 was retested 3 times: holding

[JoelSpeed]

/lgtm
/override ci/prow/verify-crdify
/override ci/prow/verify-crd-schema
/hold cancel

Removing enums in TP is not a breaking change we care about

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema, ci/prow/verify-crdify

Details

In response to this:

/lgtm
/override ci/prow/verify-crdify
/override ci/prow/verify-crd-schema
/hold cancel

Removing enums in TP is not a breaking change we care about

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JoelSpeed]

/verified bypass

Won't need verification on this TP removal, local integration tests are passing so the CRD is compatible with KAS still

[openshift-ci-robot]

@JoelSpeed: The verified label has been added.

Details

In response to this:

/verified bypass

Won't need verification on this TP removal, local integration tests are passing so the CRD is compatible with KAS still

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 230d0e0 and 2 for PR HEAD d8686b0 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3a4cc53 and 1 for PR HEAD d8686b0 in total

[openshift-ci]

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	d8686b0	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c9bef43 and 0 for PR HEAD d8686b0 in total

[openshift-ci-robot]

/hold

Revision d8686b0 was retested 3 times: holding

[JoelSpeed]

/override ci/prow/verify-crd-schema
/override ci/prow/verify-crdify

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema, ci/prow/verify-crdify

Details

In response to this:

/override ci/prow/verify-crd-schema
/override ci/prow/verify-crdify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[barbacbd]

Closing in favor of #2576. Please see #2576 (comment)