Skip to content

Revert gcp custom endpoints#2569

Closed
barbacbd wants to merge 3 commits intoopenshift:masterfrom
barbacbd:revert-gcp-custom-endpoints
Closed

Revert gcp custom endpoints#2569
barbacbd wants to merge 3 commits intoopenshift:masterfrom
barbacbd:revert-gcp-custom-endpoints

Conversation

@barbacbd
Copy link
Copy Markdown
Contributor

@barbacbd barbacbd commented Nov 5, 2025

Revert "CORS-4184: Add STS IAMCredentials and OAuth Service for GCP Endpoint Overrides"

This reverts commit c2fc60c983e28dd78953cb61d4f4e9a23279d33d.

Revert "CORS-4041: Remove the TagManager from the GCP Custom Endpoints"

This reverts commit 0cd96580db63e6b020902c0d257918540beb478c.

Revert "CORS-3842: Add API Updates for GCP Custom API Endpoints"

This reverts commit eafe808c2cd2b5d636dad29bed7c9edd22602dcd.

The featuregate is no needed with the new solution to the epic. The cluster components are no longer touched, only the openshift installer and CCM are using endpoint overrides. The CCM already contained the code for endpoint overrides.

@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger optional jobs most likely to be impacted by the proposed changes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 5, 2025

Hello @barbacbd! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 5, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@barbacbd
Copy link
Copy Markdown
Contributor Author

barbacbd commented Nov 5, 2025

/cc @JoelSpeed

@openshift-ci openshift-ci Bot requested a review from JoelSpeed November 5, 2025 19:22
@barbacbd barbacbd force-pushed the revert-gcp-custom-endpoints branch from aa9127b to 1d739ad Compare November 5, 2025 19:49
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 5, 2025

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/minor-e2e-upgrade-minor 1d739ad link true /test minor-e2e-upgrade-minor
ci/prow/integration 1d739ad link true /test integration
ci/prow/verify-crdify 1d739ad link true /test verify-crdify
ci/prow/verify-crd-schema 1d739ad link true /test verify-crd-schema
ci/prow/okd-scos-e2e-aws-ovn 1d739ad link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@barbacbd
Copy link
Copy Markdown
Contributor Author

Closing this in favor of splitting the work. The first pr here: #2576 will remove the endpoints. The second will remove the feature gate when we can.

@barbacbd barbacbd closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants