OCPBUGS-67232: Move DynamicConfigurationManager back to TPNU #2621

Miciah · 2025-12-11T17:33:15Z

Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview"

This reverts #2552.

openshift-ci-robot · 2025-12-11T17:33:18Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2025-12-11T17:33:25Z

Hello @Miciah! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot · 2025-12-11T17:33:25Z

@Miciah: This pull request references Jira Issue OCPBUGS-67232, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview"

This reverts #2552.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2025-12-11T17:33:34Z

📝 Walkthrough

Walkthrough

IngressControllerDynamicConfigurationManager is enabled for TechPreviewNoUpgrade in addition to DevPreviewNoUpgrade. The feature declaration, the features list doc, and two TechPreviewNoUpgrade FeatureGate manifests were updated to reflect this change.

Changes

Cohort / File(s)	Summary
Feature doc `features.md`	Reordered row: `IngressControllerDynamicConfigurationManager` reintroduced to show `Enabled` for `TechPreviewNoUpgrade` (Hypershift and SelfManagedHA); `DevPreviewNoUpgrade` remains `Enabled`.
Feature declaration (Go) `features/features.go`	`FeatureGateIngressControllerDynamicConfigurationManager`: `enhancementPR` set to `"https://github.com/openshift/enhancements/pull/1687"` and `enableIn` expanded to include `configv1.TechPreviewNoUpgrade` alongside `configv1.DevPreviewNoUpgrade`.
TechPreviewNoUpgrade FeatureGate manifests `payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml`, `payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml`	`IngressControllerDynamicConfigurationManager` moved from `status.disabled` to `status.enabled`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change: moving IngressControllerDynamicConfigurationManager back to TechPreviewNoUpgrade (TPNU), which is the primary objective of reverting the previous PR.
Description check	✅ Passed	The description clearly explains that this PR reverts an earlier change (`#2552`) that had moved DynamicConfigurationManager to DevPreview, which aligns with the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Miciah · 2025-12-11T19:40:05Z

Cc'ing author and reviewers from the reverted PR:
/cc @candita
/cc @alebedev87
/cc @JoelSpeed

JoelSpeed · 2025-12-11T19:44:44Z

/lgtm

BTW, this has no EP linked, is there any EP?

openshift-ci-robot · 2025-12-11T19:45:02Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

Miciah · 2025-12-11T19:46:01Z

BTW, this has no EP linked, is there any EP?

Yes: https://github.com/openshift/enhancements/blob/master/enhancements/ingress/dynamic-config-manager.md

Should I update the PR with a reference?

Miciah · 2025-12-11T19:49:29Z

Well, features/features.go links to PRs; openshift/enhancements#1687 is the PR for the EP.

JoelSpeed · 2025-12-11T20:24:20Z

Can you update l633 to remove the legacy feature gate thing and add the actual Ep link in?

Miciah · 2025-12-11T21:15:25Z

ci/prow/verify failed:

panic: FeatureGate/IngressControllerDynamicConfigurationManager enhancementPR format is incorrect; must be like https://github.com/openshift/enhancements/pull/#### or https://github.com/kubernetes/enhancements/issues/####

https://github.com/openshift/api/compare/053d7dc9eb425a835f21f151558ea7f2eb26b064..845ec5ef5e49ef176ee0567fa3d6c5f3d35ecb38 updates the link to point to the PR instead.

JoelSpeed · 2025-12-12T10:33:30Z

/lgtm

openshift-ci-robot · 2025-12-12T10:34:07Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

openshift-ci-robot · 2026-02-06T15:01:06Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:01:52Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:01:55Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:01:56Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:01:58Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:27:10Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:27:12Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:27:13Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:27:16Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:29:22Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:29:23Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-06T15:29:37Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

JoelSpeed · 2026-02-06T17:22:41Z

/verified by CI

openshift-ci-robot · 2026-02-06T17:22:55Z

@JoelSpeed: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

JoelSpeed · 2026-02-06T17:23:01Z

/retest

JoelSpeed · 2026-02-07T10:08:50Z

/retest

openshift-ci-robot · 2026-02-07T13:40:13Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci · 2026-02-07T13:40:13Z

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-02-07T13:40:14Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-07T13:40:15Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci-robot · 2026-02-07T13:44:42Z

@Miciah: Jira Issue Verification Checks: Jira Issue OCPBUGS-67232
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-67232 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview"

This reverts #2552.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-02-08T20:00:57Z

Fix included in accepted release 4.22.0-0.nightly-2026-02-08-124411

Miciah · 2026-02-09T15:28:31Z

/cherry-pick release-4.21

openshift-cherrypick-robot · 2026-02-09T15:32:40Z

@Miciah: #2621 failed to apply on top of branch "release-4.21":

Applying: Move DynamicConfigurationManager back to TPNU
Using index info to reconstruct a base tree...
M	features.md
M	features/features.go
M	payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
M	payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
Falling back to patching base and 3-way merge...
Auto-merging payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
CONFLICT (content): Merge conflict in payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
Auto-merging payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
CONFLICT (content): Merge conflict in payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
Auto-merging features/features.go
Auto-merging features.md
CONFLICT (content): Merge conflict in features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Move DynamicConfigurationManager back to TPNU

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Miciah · 2026-02-09T15:32:44Z

/jira backport release-4.21

openshift-ci-robot · 2026-02-09T15:32:58Z

@Miciah: The following backport issues have been created:

OCPBUGS-76408 for branch release-4.21

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21

Details

In response to this:

/jira backport release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-02-09T15:33:46Z

@openshift-ci-robot: #2621 failed to apply on top of branch "release-4.21":

Applying: Move DynamicConfigurationManager back to TPNU
Using index info to reconstruct a base tree...
M	features.md
M	features/features.go
M	payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
M	payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
Falling back to patching base and 3-way merge...
Auto-merging payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
CONFLICT (content): Merge conflict in payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
Auto-merging payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
CONFLICT (content): Merge conflict in payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
Auto-merging features/features.go
Auto-merging features.md
CONFLICT (content): Merge conflict in features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Move DynamicConfigurationManager back to TPNU

Details

In response to this:

@Miciah: The following backport issues have been created:

OCPBUGS-76408 for branch release-4.21

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21

In response to this:

/jira backport release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested a review from lihongan December 11, 2025 17:33

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2025

openshift-ci bot requested review from JoelSpeed and everettraven December 11, 2025 17:33

openshift-ci bot requested review from alebedev87 and candita December 11, 2025 19:40

openshift-ci bot assigned JoelSpeed Dec 11, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2025

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2025

Miciah force-pushed the OCPBUGS-67232-move-DynamicConfigurationManager-back-to-TPNU branch from 053d7dc to 845ec5e Compare December 11, 2025 21:15

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2025

Miciah force-pushed the OCPBUGS-67232-move-DynamicConfigurationManager-back-to-TPNU branch from 845ec5e to 67eebfa Compare December 23, 2025 20:30

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 6, 2026

openshift-merge-bot bot merged commit c1b6765 into openshift:master Feb 7, 2026
28 checks passed

Miciah mentioned this pull request Feb 10, 2026

[release-4.21] OCPBUGS-76408: Move DynamicConfigurationManager back to TPNU #2703

Open

OCPBUGS-67232: Move DynamicConfigurationManager back to TPNU #2621

OCPBUGS-67232: Move DynamicConfigurationManager back to TPNU #2621

Uh oh!

Conversation

Miciah commented Dec 11, 2025

Uh oh!

openshift-ci-robot commented Dec 11, 2025

Uh oh!

openshift-ci bot commented Dec 11, 2025

Uh oh!

openshift-ci-robot commented Dec 11, 2025

Uh oh!

coderabbitai bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

Miciah commented Dec 11, 2025

Uh oh!

JoelSpeed commented Dec 11, 2025

Uh oh!

openshift-ci-robot commented Dec 11, 2025

Uh oh!

Miciah commented Dec 11, 2025

Uh oh!

Miciah commented Dec 11, 2025

Uh oh!

JoelSpeed commented Dec 11, 2025

Uh oh!

Miciah commented Dec 11, 2025

Uh oh!

JoelSpeed commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

JoelSpeed commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

JoelSpeed commented Feb 6, 2026

Uh oh!

JoelSpeed commented Feb 7, 2026

Uh oh!

openshift-ci-robot commented Feb 7, 2026

Uh oh!

openshift-ci bot commented Feb 7, 2026

Uh oh!

openshift-ci-robot commented Feb 7, 2026

Uh oh!

openshift-ci-robot commented Feb 7, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 7, 2026

Uh oh!

openshift-merge-robot commented Feb 8, 2026

coderabbitai bot commented Dec 11, 2025 •

edited

Loading