CNTRLPLANE-1752: Add PKI API to config.openshift.io/v1alpha1#2645
CNTRLPLANE-1752: Add PKI API to config.openshift.io/v1alpha1#2645openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new cluster-scoped PKI custom resource under config/v1alpha1 and registers PKI and PKIList in the scheme. Introduces PKI API types (PKI, PKISpec, PKICertificateManagement, PKIProfile, CustomPKIPolicy, CertificateConfig, KeyConfig with RSA/ECDSA, overrides and enums) and PKIList. Adds autogenerated deepcopy methods, generated Swagger docs, a feature-gated CRD manifest entry for pkis.config.openshift.io (ConfigurablePKI), and test YAML covering ConfigurablePKI create/update cases. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
|
Skipping CI for Draft Pull Request. |
|
Hello @sanchezl! Some important instructions when contributing to openshift/api: |
|
/test required |
|
/test unit |
|
@sanchezl: This pull request references CNTRLPLANE-1752 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
Scheduling tests matching the |
|
/verified by CI |
|
@sanchezl: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest required |
|
/retest |
|
@sanchezl It looks like the 1.35 rebase cause some minor updates that need to be made here for verify to pass. Rebasing on the |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by CI |
|
@sanchezl: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
1 similar comment
|
/retest |
|
@sanchezl: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
This PR introduces the
PKIAPI (config.openshift.io/v1alpha1) behind theConfigurablePKIfeature gate (TechPreview / DevPreview). It provides a cluster-scoped singleton resource that allows administrators to configure the cryptographic parameters (key algorithm, key size, elliptic curve) used for internally-managed certificates — including signer (CA), serving (TLS), and client certificates — with per-category overrides on top of a required set of defaults.API Structure
graph TD PKI["<b>PKI</b><br/><i>cluster-scoped singleton</i>"] PKISpec["<b>spec</b>"] CertMgmt["<b>certificateManagement</b><br/><i>union</i>"] Mode["<b>mode</b><br/><i>Unmanaged | Default | Custom</i>"] Custom["<b>custom</b><br/><i>required when mode=Custom</i>"] Defaults["<b>defaults</b> <i>(required)</i>"] Signers["<b>signerCertificates</b> <i>(optional)</i>"] Serving["<b>servingCertificates</b> <i>(optional)</i>"] Client["<b>clientCertificates</b> <i>(optional)</i>"] KeyConfig["<b>key</b><br/><i>union: algorithm</i>"] RSA["<b>rsa</b><br/>keySize: 2048–8192<br/><i>(multiples of 1024)</i>"] ECDSA["<b>ecdsa</b><br/>curve: P256 | P384 | P521"] PKI --> PKISpec --> CertMgmt CertMgmt --> Mode CertMgmt --> Custom Custom --> Defaults Custom --> Signers Custom --> Serving Custom --> Client Defaults --> KeyConfig Signers -.->|"optional override"| KeyConfig Serving -.->|"optional override"| KeyConfig Client -.->|"optional override"| KeyConfig KeyConfig --> RSA KeyConfig --> ECDSAModes
custom. Adefaultsblock is required; optional per-category overrides (signerCertificates,servingCertificates,clientCertificates) take precedence when present.Example (Custom mode with ECDSA defaults, RSA override for signers)
Links