Skip to content

introduce degraded condition #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Apr 17, 2019
Merged

introduce degraded condition #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/v1/types_cluster_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ type ClusterVersionStatus struct {
// conditions provides information about the cluster version. The condition
// "Available" is set to true if the desiredUpdate has been reached. The
// condition "Progressing" is set to true if an update is being applied.
// The condition "Failing" is set to true if an update is currently blocked
// The condition "Degraded" is set to true if an update is currently blocked
// by a temporary or permanent error. Conditions are only valid for the
// current desiredUpdate when metadata.generation is equal to
// status.generation.
Expand Down
2 changes: 1 addition & 1 deletion config/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions operator/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ var (
OperatorStatusTypeProgressing = "Progressing"
// Failing indicates that the operator (not the operand) is unable to fulfill the user intent
Copy link
Copy Markdown
Contributor

@danehans danehans Apr 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Failing type comment need to be updated since it's the same as Degraded?

OperatorStatusTypeFailing = "Failing"
// Degraded indicates that the operator (not the operand) is unable to fulfill the user intent
OperatorStatusTypeDegraded = "Degraded"
// PrereqsSatisfied indicates that the things this operator depends on are present and at levels compatible with the
// current and desired states.
OperatorStatusTypePrereqsSatisfied = "PrereqsSatisfied"
Expand Down