Add Custom product name and logo to api #304
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XS
|
/retest |
|
/retest |
|
/retest |
openshift-ci-robot
added
size/S
|
/retest |
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
Yeah, now this looks reasonable.
openshift-ci-robot
added
the
approved
zherman0
force-pushed
the
api-custom-branding
branch
from
f80b650 to
9880402
Compare
zherman0
changed the title
openshift-ci-robot
added
needs-rebase
| // - ConfigMap.binaryData["filename"] - logo in binary form. | ||
| // This is best generated using: oc create configmap my-branding-config --from-file=/path/to/file -n openshift-config | ||
| // Image size must be less than 1 MB due to constraints on configmap size | ||
| // +optional |
There was a problem hiding this comment.
Maybe
// customLogoFile replaces the default OpenShift logo in the masthead and about dialog. It is a reference to a
// ConfigMap in the openshift-config namespace. This can be created with a command like
// 'oc create configmap custom-logo --from-file=/path/to/logo.svg -n openshift-config'.
// Image size must be less than 1 MB due to constraints on the ConfigMap size.
// The ConfigMap key should include a file extension so that the console serves the file
// with the correct MIME type.
// +optionalThere was a problem hiding this comment.
We might want to give guidance on recommended dimensions (although I don't know what those are offhand).
There was a problem hiding this comment.
It looks like we set the viewbox to 100x100 on the SVGs. Should I add that?
There was a problem hiding this comment.
@spadgett
// Recommended logo is of type svg or logo size of 100px x 100px
There was a problem hiding this comment.
100x100 can't be right since the logo is not square.
Maybe we simply say "An SVG logo is recommended, but other image types are supported." and leave it at that.
There was a problem hiding this comment.
Seems like we should indicate a recommended size, along with svg so its scalable. Our own logos:
https://github.com/openshift/console/blob/master/frontend/public/imgs/openshift-dedicated-logo.svg
https://github.com/openshift/console/blob/master/frontend/public/imgs/openshift-online-logo.svg
Are 40px high, but width is variable, roughly 260px in browser.
There was a problem hiding this comment.
@zherman0 the PatternFly variable --pf-c-page__header-brand-link--c-brand--MaxHeight sets a max-height: 3.75rem which is approximately 68px. So if the image is larger than 68px it will scale down proportionally.
I would say
// Recommended logo specifications:
// Dimensions: Max height of 68px and max width of 200px
// SVG format preferred
9880402 to
97d6c43
Compare
openshift-ci-robot
removed
the
needs-rebase
zherman0
force-pushed
the
api-custom-branding
branch
from
65386b6 to
4e53529
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, spadgett, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8 participants
Update the operator types for console to include a customizable product name and logo file