Skip to content

Remove wildcard comments from proxy. #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Jun 18, 2019
Merged

Remove wildcard comments from proxy. #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions config/v1/types_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,7 @@ type ProxySpec struct {
HTTPSProxy string `json:"httpsProxy,omitempty"`

// noProxy is a comma-separated list of hostnames and/or CIDRs for which the proxy should not be used.
// Each name is matched as either a domain which contains the host name as a suffix, or the host name itself.
// For instance, example.com would match example.com, example.com:80, and www.example.com.
// Wildcard(*) characters are not accepted, except a single * character which matches all hosts
// and effectively disables the proxy. Empty means unset and will not result in an env var.
// Empty means unset and will not result in an env var.
// +optional
NoProxy string `json:"noProxy,omitempty"`
}
Expand Down
2 changes: 1 addition & 1 deletion config/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.