Add oVirt platform status#369
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rgolangh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @rgolangh. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Roy Golan <rgolan@redhat.com>
|
/cc @coreydaley @ironcladlou @deads2k PTAL |
|
@rgolangh: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rgolangh: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close closing without prejudice to due to age. |
|
@deads2k: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@deads2k please re-open and review - I rebased it |
Adding platform status for oVirt to include the ip's needed to implement a self sufficient cluster, which doesn't rely on external DNS services to bootstrap etcd, and to have the kubernetes API reachable to all internal components.
I kept the field names exactly the same as 'baremetal' and gave thought to inheriting them. Since the two platforms will have different needs or at least to avoid coupling I decided to just have ovirt platform specific fields rather than just a base Baremetal struct that I would embed.