Skip to content

Add oVirt platform status#369

Closed
rgolangh wants to merge 1 commit intoopenshift:masterfrom
rgolangh:ovirt
Closed

Add oVirt platform status#369
rgolangh wants to merge 1 commit intoopenshift:masterfrom
rgolangh:ovirt

Conversation

@rgolangh
Copy link
Copy Markdown
Contributor

@rgolangh rgolangh commented Jul 9, 2019

Adding platform status for oVirt to include the ip's needed to implement a self sufficient cluster, which doesn't rely on external DNS services to bootstrap etcd, and to have the kubernetes API reachable to all internal components.

I kept the field names exactly the same as 'baremetal' and gave thought to inheriting them. Since the two platforms will have different needs or at least to avoid coupling I decided to just have ovirt platform specific fields rather than just a base Baremetal struct that I would embed.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rgolangh
To complete the pull request process, please assign deads2k
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

Hi @rgolangh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Roy Golan <rgolan@redhat.com>
@rgolangh
Copy link
Copy Markdown
Contributor Author

/cc @coreydaley @ironcladlou @deads2k PTAL

@openshift-ci-robot
Copy link
Copy Markdown

@rgolangh: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @coreydaley @ironcladlou @deads2k PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

@rgolangh: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2019
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Sep 25, 2019

/close

closing without prejudice to due to age.

@openshift-ci-robot
Copy link
Copy Markdown

@deads2k: Closed this PR.

Details

In response to this:

/close

closing without prejudice to due to age.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rgolangh
Copy link
Copy Markdown
Contributor Author

@deads2k please re-open and review - I rebased it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants