Skip to content

Add vSphere platform status#541

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jcpowermac:vsphere_ipi
Jan 15, 2020
Merged

Add vSphere platform status#541
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jcpowermac:vsphere_ipi

Conversation

@jcpowermac
Copy link
Copy Markdown
Contributor

@jcpowermac jcpowermac commented Dec 11, 2019

Like the other non-cloud platforms adding
vSphere to include status struct for virtual
ip addresses.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2019
@jcpowermac
Add vSphere platform status
43ea6aa 
Like the other non-cloud platforms adding
vSphere to include status struct for virtual
ip addresses.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2019
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jan 10, 2020

Enhancements:
vSphere IPI: openshift/enhancements#154
Baremetal Networking: openshift/enhancements#148

@jcpowermac jcpowermac changed the title [wip] Add vSphere platform status Add vSphere platform status Jan 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2020
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jan 13, 2020

@adambkaplan when you have a moment can you PTAL?

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jan 15, 2020

/assign @eparis

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jan 15, 2020

the API is acceptable (consistent and well-formed), but I cannot speak for whether it is correct.

/approve

@sdodson please find someone from the installer to have a look for correctness and/or completeness of the status here.

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jan 15, 2020

@sdodson please find someone from the installer to have a look for correctness and/or completeness of the status here.

if it changes significantly, please hold so I can have another look.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@mtnbikenc mtnbikenc mentioned this pull request Jan 15, 2020
Merged
1 task
@mtnbikenc
Copy link
Copy Markdown
Member

mtnbikenc commented Jan 15, 2020

LGTM, however no permissions

@sdodson sdodson added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Jan 15, 2020 •
edited
Loading

LGTM, however no permissions

I've applied the label on your behalf.

@jcpowermac jcpowermac mentioned this pull request Jan 15, 2020
Merged
@openshift-merge-robot openshift-merge-robot merged commit 491a9ce into openshift:master Jan 15, 2020
@patrickdillon patrickdillon mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees

@eparis eparis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jcpowermac @deads2k @openshift-ci-robot @mtnbikenc @sdodson @eparis @openshift-merge-robot